[perl #58036] [BUG] [PATCH] config/auto/warnings.pm not cleaning up after itself properly

[via RT]

# New Ticket Created by  James Keenan 
# Please include the string:  [perl #58036]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=58036 >


This is the same problem for which I submitted a patch yesterday with  
respect to config/auto/attributes.pm.  auto::warnings opens up a  
handle to a file called test.cco to record error output, but fails to  
delete that file at the end of the step.  In addition, auto::warnings  
lacked a $conf->cc_clean().  This patch, which I am going to apply  
before the release, fixes that.

Thank you very much.
kid51


Index: config/auto/warnings.pm
===================================================================
--- config/auto/warnings.pm     (revision 30277)
+++ config/auto/warnings.pm     (working copy)
@@ -227,9 +227,15 @@
     );
     _set_warning($conf, $warning, $exit_code, $verbose);
 
-    return if $exit_code;
+    $conf->cc_clean();
 
+    if ($exit_code) {
+        unlink $output_file or die "Unable to unlink $output_file: $!";
+        return;
+    }
+
     my $output = Parrot::BuildUtil::slurp_file($output_file);
+    unlink $output_file or die "Unable to unlink $output_file: $!";
     return _set_ccflags($conf, $output, $tryflags, $verbose);
 }