On Wed Sep 10 16:07:58 2008, szbalint wrote: > This TODO doesn't really make sense because the tests which would need > to create proper temporary files do not actually create any files, they > just read some and parse. > > Therefor I think this ticket can be resolved simply by removing the text > from smartlinks.t referring to this ticket.
szbalint also wrote on #parrot: > I was thinking about taking RT #46783 , but when I looked at > smartlinks.t it turned out the TODO-ed tests do not actually > create files temporary or otherwise. I'm just a little confused > now, is there some policy to create special test files to > _read_ from, instead of using docs/pdds/pdd03_calling_conventions.pod' > for example, or the todo is a false alarm? You are correct. (1) The one remaining TODO-ed test does not create files. No need for tempfiles there. (2) The four tests which make reference to this ticket need POD to test. If docs/pdds/pdd03_calling_conventions.pod has enough variety of POD functionality for the purpose of the smartlinks test, then I don't see a compelling reason to, e.g., create a tempdir and copy the POD file into that tempdir for the purpose of testing. So I applied your patch in r30979. I'll leave the RT open for a couple of days in case anyone objects to your/my rationale. Thank you very much. kid51
