Igor wrote:
<snip>
Hi Christoph,
I send you the patch attached.
Sincerely,
Igor
Hi Igor,
Thanks again for taking the time to contribute.
Here are some pointers:
First, you're trying too hard. I'm sorry to tell you that after you've spent
so much effort, but this change should be fairly minimal. I'm sure you've
noticed that there are two tests in t/distro/test_file_coverage.t that almost
do what you need done. Try copy/pasting code from those tests in the PMC
block and modifying it to check for the files you're interested in. Don't
worry about the PMC: label. You can give it a more appropriate name once the
rest of the test works.
A good rule is to try to use as little code as possible to get the job done.
This doesn't mean that you should use weird one-liners that nobody can
understand, but that you should strive to write simple, easily understood
code. Line 88 in the file is a fairly good example of what *not* to do,
although it'd be ok with a brief explanatory comment.
Also, don't worry too much about generalizing beyond what's needed to get the
current job done. If the code starts to look ugly, it can be refactored later.
I hope that sets you in the right direction. Feel free to email me if you
have any questions.
Christoph
