On Fri, Oct 3, 2008 at 12:13 PM, Geoffrey Broadwell <[EMAIL PROTECTED]> wrote:
> On Fri, 2008-10-03 at 08:55 -0700, Will Coleda wrote:
>> Index: Makefile.PL
>> ===================================================================
>> -BEGIN { require 5.008 }
>> +BEGIN { require 5.8.6 }
>
>> Index: Configure.pl
>> ===================================================================
>> -use 5.008;
>> +use 5.8.6;
>
> I understand that it doesn't matter for anything used post-configure,
> because in theory the user should have gotten a friendly error message
> at configure time and not even make it to the other files -- but for
> these two files, I believe we should use the backward compatible syntax,
> so that ancient Perls will be friendly to people just trying to get
> started.
>
> (From `perldoc -f use`:
>
> Specifying VERSION as a literal of the form v5.6.1 should generally be
> avoided, because it leads to misleading error messages under earlier
> versions of Perl (that is, prior to 5.6.0) that do not support this
> syntax.  The equivalent numeric version should be used instead.
>
>    use v5.6.1;         # compile time version check
>    use 5.6.1;          # ditto
>    use 5.006_001;      # ditto; preferred for backwards compatibility
> )
>
>
> -'f
>

Fair enough. For these two files, I recommend something more like:

  use 5.008; # get nice error on older perls
  use 5.8.6; # our actual requirement

Which is from the slightly updated 5.10 docs for use. Whoever applies
the patch, make it so. =-)

-- 
Will "Coke" Coleda

Reply via email to