Hi Ynon,

On Thu, 26 Dec 2013 07:48:57 +0200
ynon perek <ynonpe...@gmail.com> wrote:

> read it here:
> http://www.catalystframework.org/calendar/2013/26
> 
> comments are welcomed.
> 

thanks for having written this article. Isn't the 26 of December after Christmas
so it's not supposed to be after Advent?

In any case, a few comments (from just skimming the article):

1. Wouldn't "use parent" be preferable over "use base"?

2. You called a subroutine "all" and it is not used like List::MoreUtils' one.

Regards,

        Shlomi Fish

-- 
-----------------------------------------------------------------
Shlomi Fish       http://www.shlomifish.org/
Buffy Factoids - http://www.shlomifish.org/humour/bits/facts/Buffy/

Bugs are too afraid to reproduce on Chuck Norris’ computer. As a result, when
he uses Microsoft Windows, it behaves just like a Linux system.
    — http://www.shlomifish.org/humour/bits/facts/Chuck-Norris/

Please reply to list if it's a mailing list post - http://shlom.in/reply .
_______________________________________________
Perl mailing list
Perl@perl.org.il
http://mail.perl.org.il/mailman/listinfo/perl

Reply via email to