Hello,

Sean Gabriel Heacock wrote:
On Tue, 2007-10-02 at 19:42 +0300, Rommer wrote:
New patches :)

Awesome :)  I won't have a chance to test them on my production server
until later tonight, so for now I made a third release candidate with
the patches.  I included the dump_server_env_image() function, and added
#ifdefs around the contents of the dump functions, so if debugging isn't
enabled it doesn't waste time going through the for() loops.


I'm testing this on production server now.
But I found that graceful restarts was broken by my peruser-0.3.0rc2-senv2.patch
Attached patch fix it.

Also
#if MPM_PERUSER_DEBUG
replaced by
#ifdef MPM_PERUSER_DEBUG
because of compilation problems

diff -Nru a/server/mpm/experimental/peruser/peruser.c b/server/mpm/experimental/peruser/peruser.c
--- a/server/mpm/experimental/peruser/peruser.c	2007-10-03 16:11:15.892730258 +0300
+++ b/server/mpm/experimental/peruser/peruser.c	2007-10-03 18:00:54.296380276 +0300
@@ -438,7 +438,7 @@
 
 void dump_child_table()
 {
-#if MPM_PERUSER_DEBUG
+#ifdef MPM_PERUSER_DEBUG
   int x;
   server_env_t *senv;
 
@@ -465,7 +465,7 @@
 
 void dump_server_env_image()
 {
-#if MPM_PERUSER_DEBUG
+#ifdef MPM_PERUSER_DEBUG
   int x;
   _DBG("%-3s %-7s %-7s", "N", "INPUT", "OUTPUT");
   for(x = 0; x < NUM_SENV; x++)
@@ -2486,11 +2486,13 @@
         _DBG("Total children of %d leaving behind for graceful restart (%d living)", 
                        grace_children, grace_children_alive);
 
+	/* destroy server_env_image */
         for (i = 0; i < NUM_SENV; i++)
         {
             close(SENV[i].input);
             close(SENV[i].output);
         }
+	cleanup_server_environments(NULL);
     }
     else {
 	/* Kill 'em off */
_______________________________________________
Peruser mailing list
[email protected]
http://www.telana.com/mailman/listinfo/peruser

Reply via email to