I see Jed has a "User provided function" exception in PetscCheck__FUNCT__(). I was thinking of this issue [user code warnings with no funct usage] - when I suggested the configure option.
So - at this point - I'm fine with current code.. Satish On Sat, 28 Aug 2010, Barry Smith wrote: > > On Aug 28, 2010, at 7:57 PM, Satish Balay wrote: > > > > > > > The addition in my sugestion was to have a configure option to > > enable-disable PetscCheck__FUNCT__() > > > It is fine to have that configure option. My concern is the default, if > we default off then no one will remember to turn it on and test if we default > on then it will annoy many users. I say default off and make some nightly > builds have it on. > > Barry > > > > Satish > > > >> > >> Barry > >>> > >>> The error check option [for __FUNCT__ being correct] should just be a > >>> special case test for us - or users - so an explicit configure can be > >>> used for it. > >>> > >>> Satish > >> > >> > > > >
