Good argument. Make the change requiring setting both. Barry
On Wed, 29 Aug 2007, Lisandro Dalcin wrote: > On 8/29/07, Barry Smith <bsmith at mcs.anl.gov> wrote: > > On Wed, 29 Aug 2007, Lisandro Dalcin wrote: > > > Now, other issue, regarding this adition. Currently, passing > > > '-ksp_norm_type NO' ALSO set KSPSkipConverged. Should I remove that? > > > > No, I think it should remain the same. > > OK, but then there is something that is a bit confusing IMHO, > > 1- if you use command line your automatically get KSP_NORM_NO + > KSPSkipConverged > > 1- if you call KSPSetNormType(ksp, KSP_NORM_NO), you do not get > SkipConverged. Perhaps KSPSetNormType() should be in charge of setting > SkipConverged()? Or is this too much second-guessing the user? > > >
