On Thu, Feb 7, 2013 at 6:36 PM, Jed Brown <jedbrown at mcs.anl.gov> wrote:
> > On Thu, Feb 7, 2013 at 5:18 PM, Matthew Knepley <knepley at gmail.com> wrote: > >> 5) >>> #define KSPGMRES "gmres" >>> >>> ? >>> >> >> We had this argument. The typedef behaves in a weird was with 'const'. >> > > Huh? We already have typedef const char *KSPType. It's easy to replace > these with constant data (extern KSPType KSPGMRES), but that's harder to > read and we still have to define it for Fortran as well. > Brain melt down. I am only half looking now. > >> >>> 6) >>> #if defined(PETSC_HAVE_SOMEINCLUDE) >>> #include <someinclude.h> >>> >>> I was thinking we could auto generate empty someinclude.h for these >>> (putting in $PETSC_ARCH/include) Cheesy but ? >>> >> >> Hmm, that seems fragile. I would rather generate the header lists. >> > > Where is the programmer going to state which headers they need in a > specific source file? > Hmm, it seems like the easiest thing to do is delete them if they don't exist. Matt -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20130207/8f6e0250/attachment-0001.html>
