Barry, I've pushed a quick fix (missing PETSC_EXTERN in TaoMonitor()) in your branch.
The following prototypes in petsctao.h are also missing PETSC_EXTERN, and I think they should be more properly namespaced. PetscErrorCode VecGetSubVec(Vec, IS, PetscInt, PetscReal, Vec*); PetscErrorCode MatGetSubMat(Mat, IS, Vec, TaoSubsetType, Mat*); Perhaps you should move these prototypes (as well as TaoSubsetType) to taoimpl.h ? I'm not sure these routines should be part of the public interface. On 17 February 2014 23:16, Barry Smith <[email protected]> wrote: > > On Feb 17, 2014, at 2:17 AM, Lisandro Dalcin <[email protected]> wrote: > >> What's your opinion about renaming TaoTerminationReason -> >> TaoConvergedReason ? > > Done. Also for TaoLineSearchTerminationReason > >> >> -- >> Lisandro Dalcin >> --------------- >> CIMEC (UNL/CONICET) >> Predio CONICET-Santa Fe >> Colectora RN 168 Km 472, Paraje El Pozo >> 3000 Santa Fe, Argentina >> Tel: +54-342-4511594 (ext 1016) >> Tel/Fax: +54-342-4511169 > -- Lisandro Dalcin --------------- CIMEC (UNL/CONICET) Predio CONICET-Santa Fe Colectora RN 168 Km 472, Paraje El Pozo 3000 Santa Fe, Argentina Tel: +54-342-4511594 (ext 1016) Tel/Fax: +54-342-4511169
