> On Apr 4, 2015, at 5:34 PM, Andrew Spott <[email protected]> wrote: > > Thanks! I hadn't gotten around to fixing this yet. > > In the future: do I need to submit another pull request to fix problems like > this? Since I don’t have write access to next.
Here is how it could work if you were to do the fix 1) You would merge the branch pr291/andrewspott/andrewspott/MatCreateHTranspose/master into your branch, 2) do the fix and test in your branch 3) reply to my comment in the pull request to let everyone know about the fix I (or someone) would then 1) merge your branch into pr291/andrewspott/andrewspott/MatCreateHTranspose/master (brings in your fix) 2) then merge that into next 3) reply to your comment in pull request letting everyone know I put the new fix in Creating a new pull request for fixes to a pull request makes it hard to track what is what, it is better than all discussion stay in that one pull request. Jed may have better ideas on how to handle this; or bitch about a bad history. Barry > > -Andrew > > > > On Sat, Apr 4, 2015 at 11:22 AM, Barry Smith <[email protected]> wrote: > > > Fixed in the branch pr291/andrewspott/andrewspott/MatCreateHTranspose/master > and in next > > > > On Apr 4, 2015, at 9:00 AM, PETSc checkBuilds > > <[email protected]> wrote: > > > > > > > > Dear PETSc developer, > > > > This email contains listings of contributions attributed to you by > > `git blame` that caused compiler errors or warnings in PETSc automated > > testing. Follow the links to see the full log files. Please attempt to fix > > the issues promptly or let us know at [email protected] if you are > > unable > > to resolve the issues. > > > > Thanks, > > The PETSc development team > > > > ---- > > > > warnings attributed to commit d0de224 Added support for a > > "MatCreateHermitianTranspose" that acts the same as "MatCreateTranspose". > > > > src/mat/examples/tests/ex175.c:24 > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/04/04/examples_next_arch-mswin_ps3.log] > > > > C:\cygwin\home\sbalay\PETSC~1.CLO\src\mat\examples\tests\ex175.c(24) : > > error C2059: syntax error : 'bad suffix on number' > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/04/04/examples_next_arch-mswin-cxx-cmplx_ps3.log] > > > > C:\cygwin\home\sbalay\PETSC~2.CLO\src\mat\examples\tests\ex175.c(24) : > > error C2146: syntax error : missing ';' before identifier 'I' > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/04/04/examples_next_arch-mswin-cxx-cmplx_ps3.log] > > > > C:\cygwin\home\sbalay\PETSC~2.CLO\src\mat\examples\tests\ex175.c(24) : > > error C2059: syntax error : 'bad suffix on number' > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/04/04/examples_next_arch-mswin-cxx-cmplx_ps3.log] > > > > C:\cygwin\home\sbalay\PETSC~2.CLO\src\mat\examples\tests\ex175.c(24) : > > error C2065: 'I' : undeclared identifier > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/04/04/examples_next_arch-linux-c89_thrash.log] > > > > /sandbox/petsc/petsc.clone-2/src/mat/examples/tests/ex175.c:24:15: warning: > > imaginary constants are a GCC extension > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/04/04/examples_next_arch-mswin_ps3.log] > > > > C:\cygwin\home\sbalay\PETSC~1.CLO\src\mat\examples\tests\ex175.c(24) : > > error C2146: syntax error : missing ';' before identifier 'I' > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/04/04/examples_next_arch-mswin_ps3.log] > > > > C:\cygwin\home\sbalay\PETSC~1.CLO\src\mat\examples\tests\ex175.c(24) : > > error C2065: 'I' : undeclared identifier > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/04/04/examples_next_arch-linux-gcc-absoft_churn.log] > > > > /sandbox/petsc/petsc.clone/src/mat/examples/tests/ex175.c:24:9: error: > > cannot convert '__complex__ double' to 'PetscScalar {aka double}' in > > assignment > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/04/04/examples_next_arch-osx-10.6-cxx-pkgs-opt_petsc-mini.log] > > > > /Users/petsc/petsc.clone-2/src/mat/examples/tests/ex175.c:24: error: cannot > > convert 'double __complex__' to 'PetscScalar' in assignment > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2015/04/04/examples_next_arch-linux-opt-cxx-quad_cg.log] > > > > /sandbox/petsc/petsc.clone/src/mat/examples/tests/ex175.c:24:9: error: > > cannot convert '__complex__ double' to 'PetscScalar {aka __float128}' in > > assignment > > > > ---- > > To opt-out from receiving these messages - send a request to > > [email protected]. > >
