Barry Smith <[email protected]> writes: > Jed, > > Any reason we should not turn on --with-visibility by default when it > works?
I would like it turned on. One "downside" is that users can't simply
include a private header to hack something using private functions --
those symbols are actually private. (Of course you can still access the
structs.)
I have a PETSC_ARCH that uses visibility, so at least one of us has been
testing it.
> def checkVisibility(self):
> if self.argDB['with-visibility']:
> if not self.checkCompile('','__attribute__((visibility ("default")))
> int foo(void);'):
> raise RuntimeError('Cannot use visibility attributes')
> self.addDefine('USE_VISIBILITY',1)
>
> Currently we don't seem to use it hence to what end?
>
> Barry
>
>
> I came across this because I noticed we currently had a huge amount of
> private symbols exposed for no apparent reason except lack of testing/use.
signature.asc
Description: PGP signature
