I spent a couple minutes verifying that there is no code path where that variable is not initialized on line 3437.
-Wmaybe-uninitialized seems to generate a lot of false positives. Coupled with the blame digest's poor ability to assign blame, this proactive approach seems to waste more time than a reactive SEGV->valgrind->fix approach. Cheers, Toby On Fri, Apr 08, 2016 at 02:12:22PM -0500, Satish Balay wrote: > This should have been sent to Toby. > > I don't really understand the issue here. Its triggered by > --with-debugging=0. I'm > not sure why these compilers are pointing to petscsys.h. I get slightly > different message > on my laptop. > > mpicc -c -fPIC -Wall -Wwrite-strings -Wno-strict-aliasing > -Wno-unknown-pragmas -fvisibility=hidden -g -O -I/home/balay/petsc/include > -I/home/balay/petsc/arch-linux2-c-opt/include > -I/home/balay/soft/mpich-3.1.4/include -MMD -MP > /home/balay/petsc/src/dm/impls/plex/plextree.c -o > arch-linux2-c-opt/obj/src/dm/impls/plex/plextree.o > /home/balay/petsc/src/dm/impls/plex/plextree.c: In function > ‘DMPlexComputeInjectorTree’: > /home/balay/petsc/src/dm/impls/plex/plextree.c:3484:11: warning: > ‘childrenMats’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > ierr = PetscFree(refPointFieldMats);CHKERRQ(ierr); > ^ > /home/balay/petsc/src/dm/impls/plex/plextree.c:3507:18: note: ‘childrenMats’ > was declared here > PetscScalar ***childrenMats; > ^ > > Satish > > On Fri, 8 Apr 2016, PETSc checkBuilds wrote: > > > > > > > Dear PETSc developer, > > > > This email contains listings of contributions attributed to you by > > `git blame` that caused compiler errors or warnings in PETSc automated > > testing. Follow the links to see the full log files. Please attempt to fix > > the issues promptly or let us know at [email protected] if you are > > unable > > to resolve the issues. > > > > Thanks, > > The PETSc development team > > > > ---- > > > > warnings attributed to commit > > https://bitbucket.org/petsc/petsc/commits/49d7da5 > > PetscMalloc: allow ptr=malloc(0) and free(ptr) > > > > include/petscsys.h:1157 > > > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/04/08/build_next_arch-freebsd-cxx-pkgs-opt_wii.log] > > /usr/home/balay/petsc.clone-2/include/petscsys.h:1157:88: warning: > > 'childrenMats' may be used uninitialized in this function > > [-Wmaybe-uninitialized] > > > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/04/08/build_next_arch-linux-opt-cxx-quad_grind.log] > > /sandbox/petsc/petsc.clone-3/include/petscsys.h:1157:88: warning: > > 'childrenMats' may be used uninitialized in this function > > [-Wmaybe-uninitialized] > > > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/04/08/build_next_arch-freebsd-pkgs-opt_wii.log] > > /usr/home/balay/petsc.clone/include/petscsys.h:1157:39: warning: > > 'childrenMats' may be used uninitialized in this function > > [-Wmaybe-uninitialized] > > > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/04/08/build_next_arch-linux-pkgs-latest_cg.log] > > /sandbox/petsc/petsc.clone-4/include/petscsys.h:1157:25: warning: > > 'childrenMats' may be used uninitialized in this function > > [-Wmaybe-uninitialized] > > > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/04/08/build_next_arch-linux-pkgs-opt_crank.log] > > /sandbox/petsc/petsc.clone/include/petscsys.h:1157:25: warning: > > 'childrenMats' may be used uninitialized in this function > > [-Wmaybe-uninitialized] > > > > ---- > > To opt-out from receiving these messages - send a request to > > [email protected]. > >
signature.asc
Description: Digital signature
