> On Jun 12, 2016, at 11:14 PM, Jed Brown <[email protected]> wrote: > > Barry Smith <[email protected]> writes: >> Less code is, of course, always most appealing. Currently >> KSPConvergedDefault() has >> >> if (normtype ==KSP_NORM_NONE) >> SETERRQ(PetscObjectComm((PetscObject)ksp),PETSC_ERR_ARG_WRONGSTATE,"Use >> KSPConvergedSkip() with KSPNormType of KSP_NORM_NONE"); >> >> presumably this is so that a user won't mistakenly set the convergence test >> after setting the norm to none and assume that the test will work? But does >> this really provide anything of value? > > I think it likely causes more confusion than it fixes. And when do people > explicitly set the convergence test to Default?
Ok, I'll make a branch to simplify the code and have KSPConvergedDefault() just return on KSP_NORM_NONE
