Why does this matter? Because other pull requests and branches are not able to move through the system when it gets constipated like this. (Yes ideally we'd have a system that could not get plugged like this but because of the current state of git and web based repository systems it is the best we can do.)
Barry > On Oct 15, 2016, at 12:57 PM, Barry Smith <[email protected]> wrote: > > > Yes I am angry! People put stuff into next that is broken and obviously > not tested and leave it there for days even though they get email every day > telling them about the failed builds and they should also be checking the > dashboard the day after they push something. If you can't test your merged > next before pushing and are not willing to fix problems that come up in the > nightly the very next day then we are going to have to turn off next access > to everyone but Satish and make everyone use pull requests for all code! > > I don't think people want this and it will slow down development a great > deal but what choice is there? > > The reason you have to fix your own mess is that only you know what > caused the mess and what the correct fix is. Reverting out people's bad > commits to next is cumbersome and error prone due to Git's design so it is > not trivial to just flush next whenever some irresponsible person messes up > next. > > So fix these problems NOW! And don't do it again. Run make alltests with > a couple of configure options such as complex and 64 bit indices to catch the > major problems before pushing to next! > > Note: I don't expect that when you push to next every single test > machine in the nightly build will be perfect; next is exactly for catching > the corner cases that only appear on strange systems. But I do expect that > your pushes will be clean on a majority of the machines and that you will fix > problems that come up promptly. > > Barry > > > > [petsc-checkbuilds] PETSc blame digest (next) 2016-10-15 > > src/snes/examples/tutorials/ex56.c:400 > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-linux-pkgs-opt_crank.log] > /sandbox/petsc/petsc.clone/src/snes/examples/tutorials/ex56.c:400:7: > error: 'two_solves' undeclared (first use in this function) > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-linux-pkgs-valgrind_el6.log] > /sandbox/petsc/petsc.clone-4/src/snes/examples/tutorials/ex56.c:400:7: > error: 'two_solves' undeclared (first use in this function) > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-freebsd-pkgs-opt_wii.log] > /usr/home/balay/petsc.clone/src/snes/examples/tutorials/ex56.c:400:7: > error: 'two_solves' undeclared (first use in this function) > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-osx-xsdk-opt_ipro.log] > /Users/petsc/petsc.clone-4/src/snes/examples/tutorials/ex56.c:400:7: > error: use of undeclared identifier 'two_solves' > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-linux-pkgs-threadcomm_el6.log] > /sandbox/petsc/petsc.clone/src/snes/examples/tutorials/ex56.c:400:7: > error: 'two_solves' undeclared (first use in this function) > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-osx-10.6_ipro.log] > /Users/petsc/petsc.clone/src/snes/examples/tutorials/ex56.c:400:7: > error: use of undeclared identifier 'two_solves' > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-linux-pkgs-64idx_thrash.log] > /sandbox/petsc/petsc.clone-3/src/snes/examples/tutorials/ex56.c:400:7: > error: 'two_solves' undeclared (first use in this function) > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-osx-10.6-cxx-pkgs-opt_ipro.log] > /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex56.c:400:7: > error: use of undeclared identifier 'two_solves' > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-linux-pkgs-cxx-mlib_el6.log] > /sandbox/petsc/petsc.clone-3/src/snes/examples/tutorials/ex56.c:400:7: > error: 'two_solves' was not declared in this scope > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-freebsd-cxx-pkgs-opt_wii.log] > /usr/home/balay/petsc.clone-2/src/snes/examples/tutorials/ex56.c:400:7: > error: 'two_solves' was not declared in this scope > > [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-linux-pkgs-dbg-ftn-interfaces_crank.log] > >> >> >> warnings attributed to commit >> https://bitbucket.org/petsc/petsc/commits/4e26cc2 >> DM: switch to using PetscDS boundary in examples >> >> src/snes/examples/tutorials/ex56.c:346 >> >> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-osx-xsdk-opt_ipro.log] >> /Users/petsc/petsc.clone-4/src/snes/examples/tutorials/ex56.c:346:37: >> warning: implicit conversion from enumeration type 'PetscBool' to different >> enumeration type 'DMBoundaryConditionType' [-Wenum-conversion] >> >> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-opensolaris-pkgs-opt_n-gage.log] >> "/export/home/petsc/petsc.clone/src/snes/examples/tutorials/ex56.c", >> line 346: warning: enum type mismatch: arg #2 >> >> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-osx-10.6_ipro.log] >> /Users/petsc/petsc.clone/src/snes/examples/tutorials/ex56.c:346:37: >> warning: implicit conversion from enumeration type 'PetscBool' to different >> enumeration type 'DMBoundaryConditionType' [-Wenum-conversion] >> >> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-linux-pkgs-cxx-mlib_el6.log] >> >> /sandbox/petsc/petsc.clone-3/src/snes/examples/tutorials/ex56.c:346:123: >> error: cannot convert 'PetscBool' to 'DMBoundaryConditionType' for argument >> '2' to 'PetscErrorCode PetscDSAddBoundary(PetscDS, DMBoundaryConditionType, >> const char*, const char*, PetscInt, PetscInt, const PetscInt*, void (*)(), >> PetscInt, const PetscInt*, void*)' >> >> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-linux-pkgs-dbg-ftn-interfaces_crank.log] >> /sandbox/petsc/petsc.clone-3/src/snes/examples/tutorials/ex56.c:346:37: >> warning: implicit conversion from enumeration type 'PetscBool' to different >> enumeration type 'DMBoundaryConditionType' [-Wenum-conversion] >> >> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-freebsd-cxx-pkgs-opt_wii.log] >> >> /usr/home/balay/petsc.clone-2/src/snes/examples/tutorials/ex56.c:346:123: >> error: cannot convert 'PetscBool' to 'DMBoundaryConditionType' for argument >> '2' to 'PetscErrorCode PetscDSAddBoundary(PetscDS, DMBoundaryConditionType, >> const char*, const char*, PetscInt, PetscInt, const PetscInt*, void (*)(), >> PetscInt, const PetscInt*, void*)' >> >> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-osx-10.6-cxx-pkgs-opt_ipro.log] >> /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex56.c:346:12: >> error: no matching function for call to 'PetscDSAddBoundary' >> >> src/snes/examples/tutorials/ex56.c:347 >> >> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-osx-xsdk-opt_ipro.log] >> /Users/petsc/petsc.clone-4/src/snes/examples/tutorials/ex56.c:347:37: >> warning: implicit conversion from enumeration type 'PetscBool' to different >> enumeration type 'DMBoundaryConditionType' [-Wenum-conversion] >> >> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-opensolaris-pkgs-opt_n-gage.log] >> "/export/home/petsc/petsc.clone/src/snes/examples/tutorials/ex56.c", >> line 347: warning: enum type mismatch: arg #2 >> >> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-osx-10.6_ipro.log] >> /Users/petsc/petsc.clone/src/snes/examples/tutorials/ex56.c:347:37: >> warning: implicit conversion from enumeration type 'PetscBool' to different >> enumeration type 'DMBoundaryConditionType' [-Wenum-conversion] >> >> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-osx-10.6-cxx-pkgs-opt_ipro.log] >> /Users/petsc/petsc.clone-2/src/snes/examples/tutorials/ex56.c:347:12: >> error: no matching function for call to 'PetscDSAddBoundary' >> >> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-linux-pkgs-dbg-ftn-interfaces_crank.log] >> /sandbox/petsc/petsc.clone-3/src/snes/examples/tutorials/ex56.c:347:37: >> warning: implicit conversion from enumeration type 'PetscBool' to different >> enumeration type 'DMBoundaryConditionType' [-Wenum-conversion] >> >> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-freebsd-cxx-pkgs-opt_wii.log] >> >> /usr/home/balay/petsc.clone-2/src/snes/examples/tutorials/ex56.c:347:114: >> error: cannot convert 'PetscBool' to 'DMBoundaryConditionType' for argument >> '2' to 'PetscErrorCode PetscDSAddBoundary(PetscDS, DMBoundaryConditionType, >> const char*, const char*, PetscInt, PetscInt, const PetscInt*, void (*)(), >> PetscInt, const PetscInt*, void*)' >> >> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2016/10/15/examples_next_arch-linux-pkgs-cxx-mlib_el6.log] >> >> /sandbox/petsc/petsc.clone-3/src/snes/examples/tutorials/ex56.c:347:114: >> error: cannot convert 'PetscBool' to 'DMBoundaryConditionType' for argument >> '2' to 'PetscErrorCode PetscDSAddBoundary(PetscDS, DMBoundaryConditionType, >> const char*, const char*, PetscInt, PetscInt, const PetscInt*, void (*)(), >> PetscInt, const PetscInt*, void*)' >> >> ---- >> To opt-out from receiving these messages - send a request to >> [email protected]. >
