Lisandro Dalcin <[email protected]> writes: > On 2 August 2017 at 17:49, Satish Balay <[email protected]> wrote: >> >> On Wed, 2 Aug 2017, Lisandro Dalcin wrote: >> >>> Is this intentional or just an oversight? >> >> Probably an oversight.. >> >>> Should it be fixed in maint? >> >> Sure - with the bug-fix branch off maint - with testing in next first.. >> > > Not sure about the proper way to add the include. I would say it > should go to petscvec.h, as SF is part of the Vec package and > libpetscvec. Do you agree?
petscao.h is not included by any other headers in the Vec package. I'm not sure why petscsf.h would be different. Why not just include it in petsc.h? > diff --git a/include/petscvec.h b/include/petscvec.h > index 2391c39..fd5a43e 100644 > --- a/include/petscvec.h > +++ b/include/petscvec.h > @@ -6,6 +6,7 @@ > > #ifndef __PETSCVEC_H > #define __PETSCVEC_H > +#include <petscsf.h> > #include <petscis.h> > #include <petscviewer.h> > > > > -- > Lisandro Dalcin > ============ > Research Scientist > Computer, Electrical and Mathematical Sciences & Engineering (CEMSE) > Extreme Computing Research Center (ECRC) > King Abdullah University of Science and Technology (KAUST) > http://ecrc.kaust.edu.sa/ > > 4700 King Abdullah University of Science and Technology > al-Khawarizmi Bldg (Bldg 1), Office # 0109 > Thuwal 23955-6900, Kingdom of Saudi Arabia > http://www.kaust.edu.sa > > Office Phone: +966 12 808-0459
signature.asc
Description: PGP signature
