On Fri, Oct 20, 2017 at 4:21 PM, Jed Brown <[email protected]> wrote:
> Matthew Knepley <[email protected]> writes: > > >> Note that TSComputeIFunction is very much like SNESComputeFunction, > >> which includes > >> > >> if (snes->vec_rhs) { > >> ierr = VecAXPY(y,-1.0,snes->vec_rhs);CHKERRQ(ierr); > >> } > >> > >> Why haven't you complained about that? > >> > > > > Good point. I did not notice. This came up because the initialization > > of input vectors is inconsistent between TSComputeIFunction() and > > TSComputeIFunctionLocal(). The former does not zero the output vec, > > but the later does. > > The latter function doesn't exist so maybe you mean > TSComputeIFunction_DMDA with ADD_VALUES? That's because the DMDA needs > it when using ADD_VALUES, just like SNESComputeFunction_DMDA. When > using INSERT_VALUES, the user is responsible for setting every entry. > Is any of this different from SNES? > No I mean TSComputeIFunction_DMLocal(). So if you use DMTSSetIFunction() you get different initialization behavior than if you use DMTSSetIFunctionLocal(). This is what Brad was complaining about originally. Matt -- What most experimenters take for granted before they begin their experiments is infinitely more interesting than any results to which their experiments lead. -- Norbert Wiener https://www.cse.buffalo.edu/~knepley/ <http://www.caam.rice.edu/~mk51/>
