I think people who are integrators should be responsible for their own pull
requests.
Barry
> On Mar 1, 2018, at 5:33 AM, Karl Rupp <[email protected]> wrote:
>
> Dear PETSc folks,
>
> I think we can do a better job when it comes to handling pull requests (PRs).
> We have several PRs piling up, which after some time (imho) get merged
> relatively carelessly instead of reaping the full benefits of a thorough
> review.
>
> In order to improve the integration of pull requests, I propose to nominate a
> PR integrator, who is a-priori responsible for *all* incoming PRs. The PR
> integrator is free to delegate a particular PR integration to someone with
> the relevant domain-specific knowledge (e.g. Matt for DMPlex-related things)
> by appropriate comments on Bitbucket. In case of delays, the PR integrator is
> also responsible for issuing reminders over time (like Barry has done in the
> past).
>
> The idea is to make daily progress with the PRs. One integration step per day
> (e.g. testing or merging to next) is presumably enough to handle the load,
> whereas things get messy if we let things pile up. Automated testing may help
> a bit in the future, but it doesn't release us from properly reviewing the
> contributed code.
>
> Any objections to my PR integrator proposal? Any volunteers? ;-)
> If nobody else wants to be the highly esteemed PR integrator, I can do it. ;-)
>
> Best regards,
> Karli
