On Wed, Jun 13, 2018 at 9:57 AM Smith, Barry F. <[email protected]> wrote:
> > > > On Jun 12, 2018, at 9:36 PM, Satish Balay <[email protected]> wrote: > > > > Sure - that will work. > > > > But ultimately - if superlu and superlu_dist are separate packages > > (and meant to be used from the same applicaton)- they should not have > > any include files - that are common. > > > > If they have common files - then there should be some version check > > that prevent the wrong version of the common file from used. > > > > Or perhaps some other better organizaton of files between the packages > > is possible. > > > > Alternative is - PETSc configure should eror out if one tries to use > > both packages at the same time. > > We don't like this at all. Applications should be able to switch > between packages at runtime not require reconfiguring and rebuild etc. > Not meaning to butt-in, but I wanted to reenforce this point from the user perspective because we do this *all the time* (superlu in serial, then superlu_dist in parallel) and would be very frustrating if it went away. Thanks, Paul > > Barry > > > > > Satish > > > > On Tue, 12 Jun 2018, Xiaoye S. Li wrote: > > > >> Satish, > >> > >> I forgot to update sequential superlu. Right now I am busy with a paper > >> deadline on Friday. If I couldn't get to it before then, will certainly > do > >> it on Saturday. > >> > >> Is it sufficient to just update the master branch, without doing a new > >> tarball release? > >> > >> Sherry > >> > >> > >> On Tue, Jun 12, 2018 at 11:00 AM, Satish Balay <[email protected]> > wrote: > >> > >>> For now - removed from next [until I figureout how to handle it] > >>> > >>> One motivation for this change is xsdk@devel build [wrt ATPESC > tutorials]. > >>> > >>> Satish > >>> > >>> On Tue, 12 Jun 2018, Smith, Barry F. wrote: > >>> > >>>> > >>>> Complain to Sherry and have her fix it before moving the new release > >>> into PETSc > >>>> > >>>> Barry > >>>> > >>>> > >>>>> On Jun 12, 2018, at 10:59 AM, Satish Balay <[email protected]> > wrote: > >>>>> > >>>>> > >>>>> $ diff superlu/SRC/superlu_enum_consts.h > >>> superlu_dist/SRC/superlu_enum_consts.h > >>>>> 16a17 > >>>>>> * January 28, 2018 > >>>>> 28c29 > >>>>> < typedef enum {NOROWPERM, LargeDiag, MY_PERMR} > >>> rowperm_t; > >>>>> --- > >>>>>> typedef enum {NOROWPERM, LargeDiag_MC64, LargeDiag_AWPM, MY_PERMR} > >>> rowperm_t; > >>>>> 34c35,36 > >>>>> < typedef enum {LUSUP, UCOL, LSUB, USUB, LLVL, ULVL} > >>> MemType; > >>>>> --- > >>>>>> //typedef enum {LUSUP, UCOL, LSUB, USUB, LLVL, ULVL, NO_MEMTYPE} > >>> MemType; > >>>>>> typedef enum {USUB, LSUB, UCOL, LUSUP, LLVL, ULVL, NO_MEMTYPE} > >>> MemType; > >>>>> 69a72,74 > >>>>>> COMM_DIAG, /* Bcast diagonal block to process column */ > >>>>>> COMM_RIGHT, /* communicate L panel */ > >>>>>> COMM_DOWN, /* communicate U panel */ > >>>>> > >>>>> So superlu and superlu_dist share the same 'superlu_enum_consts.h' > >>>>> file - but with differences that are now incompatible with each > other. > >>>>> > >>>>> I'm not sure how to resolve this.. > >>>>> > >>>>> Satish > >>>>> > >>>>> On Tue, 12 Jun 2018, PETSc checkBuilds wrote: > >>>>> > >>>>>> > >>>>>> > >>>>>> Dear PETSc developer, > >>>>>> > >>>>>> This email contains listings of contributions attributed to you by > >>>>>> `git blame` that caused compiler errors or warnings in PETSc > automated > >>>>>> testing. Follow the links to see the full log files. Please attempt > >>> to fix > >>>>>> the issues promptly or let us know at [email protected] if you > >>> are unable > >>>>>> to resolve the issues. > >>>>>> > >>>>>> Thanks, > >>>>>> The PETSc development team > >>>>>> > >>>>>> ---- > >>>>>> > >>>>>> warnings attributed to commit https://bitbucket.org/petsc/ > >>> petsc/commits/8e05559 > >>>>>> superlu_dist: update to version v5.4.0 > >>>>>> > >>>>>> src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:571 > >>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/ > >>> 2018/06/12/build_next_arch-freebsd-cxx-pkgs-opt_wii.log] > >>>>>> > > /usr/home/balay/petsc.next-2/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:571:8: > >>> error: 'LargeDiag_MC64' was not declared in this scope > >>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/ > >>> 2018/06/12/build_next_arch-linux-pkgs-cxx-mlib_el6.log] > >>>>>> /home/sandbox/petsc/petsc.next-3/src/mat/impls/aij/mpi/ > >>> superlu_dist/superlu_dist.c:571:8: error: 'LargeDiag_MC64' was not > >>> declared in this scope > >>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/ > >>> 2018/06/12/build_next_arch-osx-10.6-cxx-cmplx-pkgs-dbg_ipro.log] > >>>>>> > > /Users/petsc/petsc.next-3/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:571:8: > >>> error: use of undeclared identifier 'LargeDiag_MC64' > >>>>>> > >>>>>> src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:574 > >>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/ > >>> 2018/06/12/build_next_arch-freebsd-cxx-pkgs-opt_wii.log] > >>>>>> > > /usr/home/balay/petsc.next-2/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:574:8: > >>> error: 'LargeDiag_AWPM' was not declared in this scope > >>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/ > >>> 2018/06/12/build_next_arch-linux-pkgs-cxx-mlib_el6.log] > >>>>>> /home/sandbox/petsc/petsc.next-3/src/mat/impls/aij/mpi/ > >>> superlu_dist/superlu_dist.c:574:8: error: 'LargeDiag_AWPM' was not > >>> declared in this scope > >>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/ > >>> 2018/06/12/build_next_arch-osx-10.6-cxx-cmplx-pkgs-dbg_ipro.log] > >>>>>> > > /Users/petsc/petsc.next-3/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:574:8: > >>> error: use of undeclared identifier 'LargeDiag_AWPM' > >>>>>> > >>>>>> src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:720 > >>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/ > >>> 2018/06/12/build_next_arch-linux-pkgs-cxx-mlib_el6.log] > >>>>>> /home/sandbox/petsc/petsc.next-3/src/mat/impls/aij/mpi/ > >>> superlu_dist/superlu_dist.c:720:25: error: 'LargeDiag_MC64' was not > >>> declared in this scope > >>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/ > >>> 2018/06/12/build_next_arch-osx-10.6-cxx-cmplx-pkgs-dbg_ipro.log] > >>>>>> > > /Users/petsc/petsc.next-3/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:720:25: > >>> error: use of undeclared identifier 'LargeDiag_MC64' > >>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/ > >>> 2018/06/12/build_next_arch-freebsd-cxx-pkgs-opt_wii.log] > >>>>>> > > /usr/home/balay/petsc.next-2/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:720:25: > >>> error: 'LargeDiag_MC64' was not declared in this scope > >>>>>> > >>>>>> src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:723 > >>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/ > >>> 2018/06/12/build_next_arch-osx-10.6-cxx-cmplx-pkgs-dbg_ipro.log] > >>>>>> > > /Users/petsc/petsc.next-3/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:723:25: > >>> error: use of undeclared identifier 'LargeDiag_AWPM' > >>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/ > >>> 2018/06/12/build_next_arch-freebsd-cxx-pkgs-opt_wii.log] > >>>>>> > > /usr/home/balay/petsc.next-2/src/mat/impls/aij/mpi/superlu_dist/superlu_dist.c:723:25: > >>> error: 'LargeDiag_AWPM' was not declared in this scope > >>>>>> [http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/ > >>> 2018/06/12/build_next_arch-linux-pkgs-cxx-mlib_el6.log] > >>>>>> /home/sandbox/petsc/petsc.next-3/src/mat/impls/aij/mpi/ > >>> superlu_dist/superlu_dist.c:723:25: error: 'LargeDiag_AWPM' was not > >>> declared in this scope > >>>>>> > >>>>>> ---- > >>>>>> To opt-out from receiving these messages - send a request to > >>> [email protected]. > >>>>>> > >>>>> > >>>> > >>> > >>> > >> > > > >
