Updated PR for fixing these warnings. https://bitbucket.org/petsc/petsc/pull-requests/1033/add-more-apis-to-mathypre/diff
Satish, could you help me add changes to next for testing? Fande, On Mon, Jul 16, 2018 at 10:54 AM, Fande Kong <[email protected]> wrote: > > > On Mon, Jul 16, 2018 at 10:53 AM, Fande Kong <[email protected]> wrote: > >> >> >> On Mon, Jul 16, 2018 at 10:45 AM, Satish Balay <[email protected]> wrote: >> >>> >>> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/filtered-make_next_arch-linux-pkgs-64idx_thrash.log >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_filtered-2Dmake-5Fnext-5Farch-2Dlinux-2Dpkgs-2D64idx-5Fthrash.log&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=Tex32jmZol07NSKHedEY1vMAOU3X5Wwo3h0QksHN9iA&e=> >>> >>> >>>> >>> /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:1089:9: >>> warning: passing argument 3 of ‘HYPRE_IJMatrixAddToValues’ from >>> incompatible pointer type [enabled by default] >>> /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:1089:9: >>> warning: passing argument 5 of ‘HYPRE_IJMatrixAddToValues’ from >>> incompatible pointer type [enabled by default] >>> <<<<< >>> >>> >>>>>> >>> >>> - PetscScalar sscr[MATHYPRE_SCRATCH]; >>> - HYPRE_Int cscr[2][MATHYPRE_SCRATCH]; >>> - HYPRE_Int i,nzc; >>> + PetscScalar *sscr; >>> + PetscInt *cscr[2]; >>> + PetscInt i,nzc; >>> + void *array; >>> >>> PetscStackCallStandard(HYPRE_IJMatrixAddToValues,(hA->ij,1,& >>> nzc,(HYPRE_Int*)(rows+i),cscr[0],sscr)); >>> <<<<<<<< >>> >>> So 'nzc' and 'cscr' types got changed from HYPRE_Int to PetscInt - >>> causing this problem. >>> >>> >> I fixed it in my branch, and I will push up soon. >> >> >>> >>> And this code is wierd.. >>> >>> >>>>>>>> >>> +static PetscErrorCode MatRestoreArray_HYPRE(Mat A, PetscInt size, void >>> **array) >>> +{ >>> + Mat_HYPRE *hA = (Mat_HYPRE*)A->data; >>> + >>> + PetscFunctionBegin; >>> + *array = NULL; >>> + size = 0; >>> + hA->available = PETSC_TRUE; >>> + PetscFunctionReturn(0); >>> +} >>> + >>> <<<<< >>> >>> Why does this routine need 'size' argument? >>> >>> + size = 0; >>> >>> This is just a local variable - setting it to 0 does not do anything.. >>> >>> >> In order to have make MatRestoreArray_HYPRE and MatRestoreArray_HYPRE >> looks same. If did not do anything to size and array, and then we may have >> some warnings: unused parameters. >> > > MatRestoreArray_HYPRE and MatGetArray_HYPRE > > >> >> Should we do something like this? >> >> +static PetscErrorCode MatRestoreArray_HYPRE(Mat A, PetscInt /*size*/, >> void **/*array*/) >> +{ >> + Mat_HYPRE *hA = (Mat_HYPRE*)A->data; >> + >> + PetscFunctionBegin; >> + hA->available = PETSC_TRUE; >> + PetscFunctionReturn(0); >> +} >> >> >> Not sure C89 like this or not. If you have any idea, please let me know >> >> >> Fande, >> >> >>> >>> >>> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/filtered-make_next_arch-freebsd-cxx-pkgs-opt_wii.log >>> /usr/home/balay/petsc.next-2/src/mat/impls/hypre/mhypre.c:1075:20 >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_filtered-2Dmake-5Fnext-5Farch-2Dfreebsd-2Dcxx-2Dpkgs-2Dopt-5Fwii.log_usr_home_balay_petsc.next-2D2_src_mat_impls_hypre_mhypre.c-3A1075-3A20&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=MdGPEX6870uF0YUQJdQLQ89XEaJJMULBnSTH_3qHW4s&e=>: >>> warning: 'array' may be used uninitialized in this function >>> [-Wmaybe-uninitialized] >>> >>> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/filtered-make_next_arch-linux-opt-misc_el6.log >>> /home/sandbox/petsc/petsc.next/src/mat/impls/hypre/mhypre.c:1103:53 >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_filtered-2Dmake-5Fnext-5Farch-2Dlinux-2Dopt-2Dmisc-5Fel6.log_home_sandbox_petsc_petsc.next_src_mat_impls_hypre_mhypre.c-3A1103-3A53&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=XiGTAXejawPngic6-Hokaz5MestYv5_4LDPTBoQzIfU&e=>: >>> warning: ‘array’ may be used uninitialized in this function >>> [-Wmaybe-uninitialized] >>> >>> This is a bit wierd. Different builds are giving warnings at different >>> lines. And not all builds are warning about this. >>> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/next.html >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_next.html&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=iKNI8CQTR2xSXVHJo2bm9e4FIGKEgEiN1GpVYH-P9v4&e=> >>> >>> So - it must be the compiler/os combination.. I'll have to take a closer >>> look.. >>> >>> Satish >>> >>> >>> >>> On Mon, 16 Jul 2018, Matthew Knepley wrote: >>> >>> > On Mon, Jul 16, 2018 at 11:38 AM Fande Kong <[email protected]> >>> wrote: >>> > >>> > > Hi Satish and Barry, >>> > > >>> > > Any way to reproduce these warnings? I just tried the same configure >>> > > script on my desktop, and I did NOT see any warning. >>> > > >>> > >>> > You would need the same compiler/options. Is it not clear why they >>> happen? >>> > >>> > Matt >>> > >>> > >>> > > Fande, >>> > > >>> > > On Mon, Jul 16, 2018 at 6:28 AM, PETSc checkBuilds < >>> > > [email protected]> wrote: >>> > > >>> > >> >>> > >> >>> > >> Dear PETSc developer, >>> > >> >>> > >> This email contains listings of contributions attributed to you by >>> > >> `git blame` that caused compiler errors or warnings in PETSc >>> automated >>> > >> testing. Follow the links to see the full log files. Please >>> attempt to >>> > >> fix >>> > >> the issues promptly or let us know at [email protected] if you >>> are >>> > >> unable >>> > >> to resolve the issues. >>> > >> >>> > >> Thanks, >>> > >> The PETSc development team >>> > >> >>> > >> ---- >>> > >> >>> > >> warnings attributed to commit >>> > >> https://bitbucket.org/petsc/petsc/commits/c69f721 >>> <https://urldefense.proofpoint.com/v2/url?u=https-3A__bitbucket.org_petsc_petsc_commits_c69f721&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=5VWpjxoZ9rW530SXMhWQRSPECZA9NhwGhBVHbZBbKLU&e=> >>> > >> Added MatZeroEntries_HYPRE >>> > >> >>> > >> src/mat/impls/hypre/mhypre.c:1103 >>> > >> [ >>> > >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/build_next_arch-linux-opt-misc_el6.log >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_build-5Fnext-5Farch-2Dlinux-2Dopt-2Dmisc-5Fel6.log&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=ibtSl72l3tfTct4Jbe9cB8vS_GnqUDc9Nsr4fa6G1rs&e=> >>> > >> ] >>> > >> >>> > >> /home/sandbox/petsc/petsc.next/src/mat/impls/hypre/mhypre.c: >>> 1103:53: >>> > >> warning: 'array' may be used uninitialized in this function >>> > >> [-Wmaybe-uninitialized] >>> > >> [ >>> > >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/build_next_arch-linux-pkgs-opt_crank.log >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_build-5Fnext-5Farch-2Dlinux-2Dpkgs-2Dopt-5Fcrank.log&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=bdrZnwkskWfHXujHM7fKpqskyl-wzH8VC5ir3gp4GPs&e=> >>> > >> ] >>> > >> /sandbox/petsc/petsc.next/src/mat/impls/hypre/mhypre.c:1103 >>> :53: >>> > >> warning: 'array' may be used uninitialized in this function >>> > >> [-Wmaybe-uninitialized] >>> > >> >>> > >> src/mat/impls/hypre/mhypre.c:1105 >>> > >> [ >>> > >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/build_next_arch-linux-pkgs-64idx_thrash.log >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_build-5Fnext-5Farch-2Dlinux-2Dpkgs-2D64idx-5Fthrash.log&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=DiGS92uuT24XBHyNgxEDYzIsqrQX5kEChM4esdEi914&e=> >>> > >> ] >>> > >> /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:11 >>> 05:9: >>> > >> warning: passing argument 3 of 'HYPRE_IJMatrixSetValues' from >>> incompatible >>> > >> pointer type [enabled by default] >>> > >> [ >>> > >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/build_next_arch-linux-pkgs-64idx_thrash.log >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_build-5Fnext-5Farch-2Dlinux-2Dpkgs-2D64idx-5Fthrash.log&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=DiGS92uuT24XBHyNgxEDYzIsqrQX5kEChM4esdEi914&e=> >>> > >> ] >>> > >> /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:11 >>> 05:9: >>> > >> warning: passing argument 5 of 'HYPRE_IJMatrixSetValues' from >>> incompatible >>> > >> pointer type [enabled by default] >>> > >> >>> > >> src/mat/impls/hypre/mhypre.c:1524 >>> > >> [ >>> > >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/build_next_arch-linux-pkgs-64idx_thrash.log >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_build-5Fnext-5Farch-2Dlinux-2Dpkgs-2D64idx-5Fthrash.log&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=DiGS92uuT24XBHyNgxEDYzIsqrQX5kEChM4esdEi914&e=> >>> > >> ] >>> > >> /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:15 >>> 24:5: >>> > >> warning: assignment from incompatible pointer type [enabled by >>> default] >>> > >> >>> > >> src/mat/impls/hypre/mhypre.c:1525 >>> > >> [ >>> > >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/build_next_arch-linux-pkgs-64idx_thrash.log >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_build-5Fnext-5Farch-2Dlinux-2Dpkgs-2D64idx-5Fthrash.log&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=DiGS92uuT24XBHyNgxEDYzIsqrQX5kEChM4esdEi914&e=> >>> > >> ] >>> > >> /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:15 >>> 25:5: >>> > >> warning: assignment from incompatible pointer type [enabled by >>> default] >>> > >> >>> > >> src/mat/impls/hypre/mhypre.c:1582 >>> > >> [ >>> > >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/build_next_arch-linux-pkgs-64idx_thrash.log >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_build-5Fnext-5Farch-2Dlinux-2Dpkgs-2D64idx-5Fthrash.log&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=DiGS92uuT24XBHyNgxEDYzIsqrQX5kEChM4esdEi914&e=> >>> > >> ] >>> > >> /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:15 >>> 82:3: >>> > >> warning: passing argument 4 of 'HYPRE_ParCSRMatrixGetRow' from >>> incompatible >>> > >> pointer type [enabled by default] >>> > >> [ >>> > >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/build_next_arch-linux-pkgs-64idx_thrash.log >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_build-5Fnext-5Farch-2Dlinux-2Dpkgs-2D64idx-5Fthrash.log&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=DiGS92uuT24XBHyNgxEDYzIsqrQX5kEChM4esdEi914&e=> >>> > >> ] >>> > >> /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:15 >>> 82:3: >>> > >> warning: passing argument 3 of 'HYPRE_ParCSRMatrixGetRow' from >>> incompatible >>> > >> pointer type [enabled by default] >>> > >> >>> > >> src/mat/impls/hypre/mhypre.c:1595 >>> > >> [ >>> > >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/build_next_arch-linux-pkgs-64idx_thrash.log >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_build-5Fnext-5Farch-2Dlinux-2Dpkgs-2D64idx-5Fthrash.log&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=DiGS92uuT24XBHyNgxEDYzIsqrQX5kEChM4esdEi914&e=> >>> > >> ] >>> > >> /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:15 >>> 95:3: >>> > >> warning: passing argument 4 of 'HYPRE_ParCSRMatrixRestoreRow' from >>> > >> incompatible pointer type [enabled by default] >>> > >> [ >>> > >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/build_next_arch-linux-pkgs-64idx_thrash.log >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_build-5Fnext-5Farch-2Dlinux-2Dpkgs-2D64idx-5Fthrash.log&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=DiGS92uuT24XBHyNgxEDYzIsqrQX5kEChM4esdEi914&e=> >>> > >> ] >>> > >> /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:15 >>> 95:3: >>> > >> warning: passing argument 3 of 'HYPRE_ParCSRMatrixRestoreRow' from >>> > >> incompatible pointer type [enabled by default] >>> > >> >>> > >> src/mat/impls/hypre/mhypre.c:1613 >>> > >> [ >>> > >> http://ftp.mcs.anl.gov/pub/petsc/nightlylogs/archive/2018/07 >>> /16/build_next_arch-linux-pkgs-64idx_thrash.log >>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__ftp.mcs.anl.gov_pub_petsc_nightlylogs_archive_2018_07_16_build-5Fnext-5Farch-2Dlinux-2Dpkgs-2D64idx-5Fthrash.log&d=DwMFaQ&c=54IZrppPQZKX9mLzcGdPfFD1hxrcB__aEkJFOKJFd00&r=DUUt3SRGI0_JgtNaS3udV68GRkgV4ts7XKfj2opmiCY&m=paFK1OY_ndSgoQtSLol9nduqo9lfc1WinXao3N9040w&s=DiGS92uuT24XBHyNgxEDYzIsqrQX5kEChM4esdEi914&e=> >>> > >> ] >>> > >> /sandbox/petsc/petsc.next-3/src/mat/impls/hypre/mhypre.c:16 >>> 13:5: >>> > >> warning: passing argument 3 of 'HYPRE_IJMatrixGetValues' from >>> incompatible >>> > >> pointer type [enabled by default] >>> > >> >>> > >> ---- >>> > >> To opt-out from receiving these messages - send a request to >>> > >> [email protected]. >>> > >> >>> > > >>> > > >>> > >>> > >>> >> >> >
