This change should go into a PR? Ok - created one.
https://bitbucket.org/petsc/petsc/pull-requests/1528/ksp-correctly-deprecate/diff Satish On Tue, 9 Apr 2019, Jed Brown via petsc-dev wrote: > I think this would have the desired effect. > > diff --git i/include/petscksp.h w/include/petscksp.h > index 7b1e877e29..b0fddedfcd 100644 > --- i/include/petscksp.h > +++ w/include/petscksp.h > @@ -448,6 +448,7 @@ typedef enum {/* converged */ > KSP_DIVERGED_NANORINF = -9, > KSP_DIVERGED_INDEFINITE_MAT = -10, > KSP_DIVERGED_PC_FAILED = -11, > + KSP_DIVERGED_PCSETUP_FAILED PETSC_DEPRECATED("Use > KSP_DIVERGED_PC_FAILED") = -11, > > KSP_CONVERGED_ITERATING = 0} KSPConvergedReason; > PETSC_EXTERN const char *const*KSPConvergedReasons; > > > Matthew Knepley via petsc-dev <[email protected]> writes: > > > This change: > > > > > > https://bitbucket.org/petsc/petsc/commits/c0decd05c6848b80907752eef350b55c8c90e696#Linclude/petscksp.hF448 > > > > breaks the current LibMesh, and I am assuming other things. Do we have a > > deprecation strategy for this? How about we #define that old name to the > > same value for one release? We could do this > > in 3.11.1. > > > > Thanks, > > > > Matt > > > > -- > > What most experimenters take for granted before they begin their > > experiments is infinitely more interesting than any results to which their > > experiments lead. > > -- Norbert Wiener > > > > https://www.cse.buffalo.edu/~knepley/ <http://www.cse.buffalo.edu/~knepley/> >
