> On Jun 26, 2019, at 1:53 PM, Jed Brown <[email protected]> wrote: > > "Smith, Barry F." <[email protected]> writes: > >> It is still a PC, it may as part of its computation solve an eigenvalue >> problem but its use is as a PC, hence does not belong in SLEPc. > > Fine; it does not belong in src/ksp/pc/. Why not? From the code mangement point of view that is the perfect place for it. It just depends on an external package in the same way that PCHYPRE depends on an external library. Having it off in some other directory src/plugins would serve no purpose. Of course making sure it doesn't get compiled into -lpetsc may require a tweak to the make infrastructure. Make could, for example, skip plugin subdirectories for example. BTW: Matt's perverse use of SNES from DMPLEx could also be fixed to work this way instead of the disgusting PetscObject casting used to cancel the SNES object. Barry
Re: [petsc-dev] circular dependencies SLEPc
Smith, Barry F. via petsc-dev Wed, 26 Jun 2019 12:29:57 -0700
- Re: [petsc-dev] circular depend... Fande Kong via petsc-dev
- Re: [petsc-dev] circular depend... Balay, Satish via petsc-dev
- Re: [petsc-dev] circular depend... Matthew Knepley via petsc-dev
- Re: [petsc-dev] circular depend... Smith, Barry F. via petsc-dev
- Re: [petsc-dev] circular dependencies SLEPc Smith, Barry F. via petsc-dev
- Re: [petsc-dev] circular dependencies S... Jed Brown via petsc-dev
- Re: [petsc-dev] circular dependenci... Jed Brown via petsc-dev
- Re: [petsc-dev] circular dependencies S... Jed Brown via petsc-dev
- Re: [petsc-dev] circular dependenci... Smith, Barry F. via petsc-dev
- Re: [petsc-dev] circular depend... Jed Brown via petsc-dev
- Re: [petsc-dev] circular depend... Smith, Barry F. via petsc-dev
- Re: [petsc-dev] circular depend... Jed Brown via petsc-dev
- Re: [petsc-dev] circular depend... Jed Brown via petsc-dev
- Re: [petsc-dev] circular depend... Matthew Knepley via petsc-dev
- Re: [petsc-dev] circular depend... Pierre Jolivet via petsc-dev
- Re: [petsc-dev] circular depend... Smith, Barry F. via petsc-dev
- Re: [petsc-dev] circular depend... Jakub Kruzik via petsc-dev
- Re: [petsc-dev] circular depend... Smith, Barry F. via petsc-dev
- Re: [petsc-dev] circular depend... Jed Brown via petsc-dev
- Re: [petsc-dev] circular depend... Smith, Barry F. via petsc-dev
- Re: [petsc-dev] circular depend... Jed Brown via petsc-dev
