> On 16 Oct 2019, at 8:01 PM, Zhang, Junchao <[email protected]> wrote:
> 
> The value of "owner" should fit in PetscMPIInt.

Are you implying that BuildSystem always promotes PetscInt to be able to store 
a PetscMPIInt (what if you configure with 32 bit indices and a 64 bit MPI 
implementation)?

Thanks,
Pierre

> But if you change prototype of the two functions, you have to change all 
> their uses.
> In petsc, values representing MPI ranks are not always of type PetscMPIInt. 
> Only those closely tied to MPI routines are in PetscMPIInt.
> 
> --Junchao Zhang
> 
> 
> On Wed, Oct 16, 2019 at 5:19 AM Pierre Jolivet via petsc-dev 
> <[email protected] <mailto:[email protected]>> wrote:
> Hello,
> These two functions use a parameter “owner” of type PetscInt*.
> Shouldn’t this be PetscMPIInt*?
> This implies changes left and right, so I want to check I’m not pushing an 
> incorrect MR.
> 
> Thanks,
> Pierre

Reply via email to