-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 07/02/15 17:04, Barry Smith wrote: > > Lawrence, > > In general we do not want XXXSetFromOptions() to be randomly > called deep within constructors or other places. Ideally we want > them called either when I user calls them directly or from another > YYYSetFromOptions() that the user called. We do violate this rule > occasionally but we don't want new XXXSetFromOptions() put into > the code randomly. > > Barry > >> On Feb 7, 2015, at 7:57 AM, Jed Brown <j...@jedbrown.org> wrote: >> >> Lawrence Mitchell <lawrence.mitch...@imperial.ac.uk> writes: >>> >>> + ierr = PetscSFSetFromOptions(v->sf); >>> CHKERRQ(ierr); + ierr = >>> PetscSFSetFromOptions(v->defaultSF); CHKERRQ(ierr); >> >> Please use PetscObjectSetOptionsPrefix on the SFs and call >> PetscSFSetFromOptions in DMSetFromOptions.
Now done here: https://bitbucket.org/petsc/petsc/pull-request/270 Cheers, Lawrence -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJU7J0/AAoJECOc1kQ8PEYv7SwIAKUwFy8anEw80H+KJ5W01dCb 3koLxqu+NxBM8krpv4POYtl8cEmGK4SFmFVVc7gw08FdP9ckscHznooAvGQiwsYN R0sgtpPdwvfzg2546K2rJVGfoUpYluwvFN3bKc1uC+vFgqvZA1Em4VzslgYnMlc1 em+J2Ue7poeWMfTA/omvGMiPDpnHuY9Kk+tEQ3ca5db+ZvLOYVDvcwXeu/ITq7kE kwf7K968TkS5My46Jge09orG1QKJaHM/1fOZ5ld0//Gagowht7HKvU0bbisDFIDz LdQl7APAeXlpatzrAX0ombkpOG+Mrz45DNOwFpLwdZi12icFhMlm/7HJejITzrs= =MSCw -----END PGP SIGNATURE-----