> On Jan 11, 2022, at 8:04 PM, Jed Brown <j...@jedbrown.org> wrote:
>
> Barry Smith <bsm...@petsc.dev> writes:
>
>> Thanks for the alternative.
>>
>> @jed does this mean we need to do our casting of functions like this
>> everywhere?
>
> Whenever our interfaces accept a function with a non-unique prototype, the
> interface should take void(*)(void) instead of PetscErrorCode(*)(void).
Great. I didn't realise when I did the initial PetscErrorCode(*)(void). that
void(*)(void) was a special portable castable function prototype I have made
an issue.
>
> I think we should also be a bit more judicious about where we absolutely need
> this hack.