Hi Dave,
Please find a patch to fix the JS tests.
FYI, I have removed the labels like 'Shift+CTRL+/' from test instead used '
inlineComment' because key shortcuts are different based on platform.
Please review.
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Wed, Jul 26, 2017 at 5:32 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
> Looking into it.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Wed, Jul 26, 2017 at 5:28 PM, pgAdmin 4 Jenkins <jenk...@pgadmin.org>
> wrote:
>
>> See <https://jenkins.pgadmin.org/job/pgadmin4-master-python26/38
>> 6/display/redirect?page=changes>
>>
>> Changes:
>>
>> [Dave Page] Update keyboard shortcuts per discussion. Also, make the
>> labels platform
>>
>> ------------------------------------------
>> [...truncated 357.97 KB...]
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 59 of 254 SUCCESS (0 secs
>> / 1.953 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 60 of 254 SUCCESS (0 secs
>> / 1.958 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 61 of 254 SUCCESS (0 secs
>> / 1.964 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 62 of 254 SUCCESS (0 secs
>> / 1.969 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 63 of 254 SUCCESS (0 secs
>> / 1.974 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 64 of 254 SUCCESS (0 secs
>> / 1.979 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 65 of 254 SUCCESS (0 secs
>> / 1.988 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 66 of 254 SUCCESS (0 secs
>> / 1.993 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 67 of 254 SUCCESS (0 secs
>> / 1.997 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 68 of 254 SUCCESS (0 secs
>> / 2.002 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 69 of 254 SUCCESS (0 secs
>> / 2.007 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 70 of 254 SUCCESS (0 secs
>> / 2.012 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 71 of 254 SUCCESS (0 secs
>> / 2.017 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 72 of 254 SUCCESS (0 secs
>> / 2.022 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 73 of 254 SUCCESS (0 secs
>> / 2.027 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 74 of 254 SUCCESS (0 secs
>> / 2.033 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 75 of 254 SUCCESS (0 secs
>> / 2.037 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 76 of 254 SUCCESS (0 secs
>> / 2.042 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 77 of 254 SUCCESS (0 secs
>> / 2.078 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 78 of 254 SUCCESS (0 secs
>> / 2.082 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 79 of 254 SUCCESS (0 secs
>> / 2.116 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 80 of 254 SUCCESS (0 secs
>> / 2.142 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 81 of 254 SUCCESS (0 secs
>> / 2.166 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 82 of 254 SUCCESS (0 secs
>> / 2.195 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 83 of 254 SUCCESS (0 secs
>> / 2.219 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 84 of 254 SUCCESS (0 secs
>> / 2.248 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 85 of 254 SUCCESS (0 secs
>> / 2.27 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 86 of 254 SUCCESS (0 secs
>> / 2.29 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 87 of 254 SUCCESS (0 secs
>> / 2.311 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 88 of 254 SUCCESS (0 secs
>> / 2.331 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 89 of 254 SUCCESS (0 secs
>> / 2.351 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 90 of 254 SUCCESS (0 secs
>> / 2.37 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 91 of 254 SUCCESS (0 secs
>> / 2.414 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 92 of 254 SUCCESS (0 secs
>> / 2.435 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 93 of 254 SUCCESS (0 secs
>> / 2.456 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 94 of 254 SUCCESS (0 secs
>> / 2.476 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 95 of 254 SUCCESS (0 secs
>> / 2.492 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 96 of 254 SUCCESS (0 secs
>> / 2.508 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 97 of 254 SUCCESS (0 secs
>> / 2.531 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 98 of 254 SUCCESS (0 secs
>> / 2.546 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 99 of 254 SUCCESS (0 secs
>> / 2.587 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 100 of 254 SUCCESS (0
>> secs / 2.607 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 101 of 254 SUCCESS (0
>> secs / 2.624 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 102 of 254 SUCCESS (0
>> secs / 2.644 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 103 of 254 SUCCESS (0
>> secs / 2.663 secs)
>> [33m26 07 2017 11:58:03.312:WARN [web-server]: [39m404:
>> /base/pgadmin/static/img/select-all-icon.png
>> [33m26 07 2017 11:58:03.326:WARN [web-server]: [39m404:
>> /base/pgadmin/static/img/select-all-icon.png
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 104 of 254 SUCCESS (0
>> secs / 2.68 secs)
>> [33m26 07 2017 11:58:03.342:WARN [web-server]: [39m404:
>> /base/pgadmin/static/img/select-all-icon.png
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 105 of 254 SUCCESS (0
>> secs / 2.694 secs)
>> [33m26 07 2017 11:58:03.361:WARN [web-server]: [39m404:
>> /base/pgadmin/static/img/select-all-icon.png
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 106 of 254 SUCCESS (0
>> secs / 2.715 secs)
>> [33m26 07 2017 11:58:03.377:WARN [web-server]: [39m404:
>> /base/pgadmin/static/img/select-all-icon.png
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 107 of 254 SUCCESS (0
>> secs / 2.731 secs)
>> [33m26 07 2017 11:58:03.394:WARN [web-server]: [39m404:
>> /base/pgadmin/static/img/select-all-icon.png
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 108 of 254 SUCCESS (0
>> secs / 2.747 secs)
>> [33m26 07 2017 11:58:03.410:WARN [web-server]: [39m404:
>> /base/pgadmin/static/img/select-all-icon.png
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 109 of 254 SUCCESS (0
>> secs / 2.764 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 110 of 254 SUCCESS (0
>> secs / 2.781 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 111 of 254 SUCCESS (0
>> secs / 2.786 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 112 of 254 SUCCESS (0
>> secs / 2.79 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 113 of 254 SUCCESS (0
>> secs / 2.795 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 114 of 254 SUCCESS (0
>> secs / 2.8 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 115 of 254 SUCCESS (0
>> secs / 2.805 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 116 of 254 SUCCESS (0
>> secs / 2.81 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 117 of 254 SUCCESS (0
>> secs / 2.815 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 118 of 254 SUCCESS (0
>> secs / 2.82 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 119 of 254 SUCCESS (0
>> secs / 2.825 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 120 of 254 SUCCESS (0
>> secs / 2.83 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 121 of 254 SUCCESS (0
>> secs / 2.835 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 122 of 254 SUCCESS (0
>> secs / 2.842 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 123 of 254 SUCCESS (0
>> secs / 2.847 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 124 of 254 SUCCESS (0
>> secs / 2.851 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 125 of 254 SUCCESS (0
>> secs / 2.863 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 126 of 254 SUCCESS (0
>> secs / 2.874 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 127 of 254 SUCCESS (0
>> secs / 2.884 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 128 of 254 SUCCESS (0
>> secs / 2.894 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 129 of 254 SUCCESS (0
>> secs / 2.904 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 130 of 254 SUCCESS (0
>> secs / 2.937 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 131 of 254 SUCCESS (0
>> secs / 2.953 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 132 of 254 SUCCESS (0
>> secs / 2.967 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 133 of 254 SUCCESS (0
>> secs / 2.986 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 134 of 254 SUCCESS (0
>> secs / 3.003 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 135 of 254 SUCCESS (0
>> secs / 3.023 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 136 of 254 SUCCESS (0
>> secs / 3.041 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 137 of 254 SUCCESS (0
>> secs / 3.058 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 138 of 254 SUCCESS (0
>> secs / 3.077 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 139 of 254 SUCCESS (0
>> secs / 3.093 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 140 of 254 SUCCESS (0
>> secs / 3.137 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 141 of 254 SUCCESS (0
>> secs / 3.154 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 142 of 254 SUCCESS (0
>> secs / 3.172 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 143 of 254 SUCCESS (0
>> secs / 3.188 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 144 of 254 SUCCESS (0
>> secs / 3.204 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 145 of 254 SUCCESS (0
>> secs / 3.221 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 146 of 254 SUCCESS (0
>> secs / 3.245 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 147 of 254 SUCCESS (0
>> secs / 3.26 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 148 of 254 SUCCESS (0
>> secs / 3.276 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 149 of 254 SUCCESS (0
>> secs / 3.291 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 150 of 254 SUCCESS (0
>> secs / 3.307 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 151 of 254 SUCCESS (0
>> secs / 3.314 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 152 of 254 SUCCESS (0
>> secs / 3.319 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 153 of 254 SUCCESS (0
>> secs / 3.324 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 154 of 254 SUCCESS (0
>> secs / 3.33 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 155 of 254 SUCCESS (0
>> secs / 3.335 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 156 of 254 SUCCESS (0
>> secs / 3.34 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 157 of 254 SUCCESS (0
>> secs / 3.345 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 158 of 254 SUCCESS (0
>> secs / 3.35 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 159 of 254 SUCCESS (0
>> secs / 3.355 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 160 of 254 SUCCESS (0
>> secs / 3.365 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 161 of 254 SUCCESS (0
>> secs / 3.37 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 162 of 254 SUCCESS (0
>> secs / 3.375 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 163 of 254 SUCCESS (0
>> secs / 3.38 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 164 of 254 SUCCESS (0
>> secs / 3.386 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 165 of 254 SUCCESS (0
>> secs / 3.392 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 166 of 254 SUCCESS (0
>> secs / 3.398 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 167 of 254 SUCCESS (0
>> secs / 3.433 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 168 of 254 SUCCESS (0
>> secs / 3.454 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 169 of 254 SUCCESS (0
>> secs / 3.469 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 170 of 254 SUCCESS (0
>> secs / 3.488 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 171 of 254 SUCCESS (0
>> secs / 3.503 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 172 of 254 SUCCESS (0
>> secs / 3.519 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 173 of 254 SUCCESS (0
>> secs / 3.536 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 174 of 254 SUCCESS (0
>> secs / 3.553 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 175 of 254 SUCCESS (0
>> secs / 3.566 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 176 of 254 SUCCESS (0
>> secs / 3.58 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 177 of 254 SUCCESS (0
>> secs / 3.594 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 178 of 254 SUCCESS (0
>> secs / 3.607 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 179 of 254 SUCCESS (0
>> secs / 3.621 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 180 of 254 SUCCESS (0
>> secs / 3.634 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 181 of 254 SUCCESS (0
>> secs / 3.647 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 182 of 254 SUCCESS (0
>> secs / 3.663 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 183 of 254 SUCCESS (0
>> secs / 3.675 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 184 of 254 SUCCESS (0
>> secs / 3.692 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 185 of 254 SUCCESS (0
>> secs / 3.706 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 186 of 254 SUCCESS (0
>> secs / 3.719 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 187 of 254 SUCCESS (0
>> secs / 3.732 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 188 of 254 SUCCESS (0
>> secs / 3.744 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 189 of 254 SUCCESS (0
>> secs / 3.758 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 190 of 254 SUCCESS (0
>> secs / 3.775 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 191 of 254 SUCCESS (0
>> secs / 3.788 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 192 of 254 SUCCESS (0
>> secs / 3.8 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 193 of 254 SUCCESS (0
>> secs / 3.813 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 194 of 254 SUCCESS (0
>> secs / 3.826 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 195 of 254 SUCCESS (0
>> secs / 3.841 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 196 of 254 SUCCESS (0
>> secs / 3.854 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 197 of 254 SUCCESS (0
>> secs / 3.874 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 198 of 254 SUCCESS (0
>> secs / 3.896 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 199 of 254 SUCCESS (0
>> secs / 3.909 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 200 of 254 SUCCESS (0
>> secs / 3.922 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 201 of 254 SUCCESS (0
>> secs / 3.935 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 202 of 254 SUCCESS (0
>> secs / 3.939 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 203 of 254 SUCCESS (0
>> secs / 3.943 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 204 of 254 SUCCESS (0
>> secs / 3.948 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 205 of 254 SUCCESS (0
>> secs / 3.956 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 206 of 254 SUCCESS (0
>> secs / 3.96 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 207 of 254 SUCCESS (0
>> secs / 3.964 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 208 of 254 SUCCESS (0
>> secs / 3.969 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 209 of 254 SUCCESS (0
>> secs / 3.973 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 210 of 254 SUCCESS (0
>> secs / 3.977 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 211 of 254 SUCCESS (0
>> secs / 3.981 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 212 of 254 SUCCESS (0
>> secs / 4.002 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 213 of 254 SUCCESS (0
>> secs / 4.056 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 214 of 254 SUCCESS (0
>> secs / 4.072 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 215 of 254 SUCCESS (0
>> secs / 4.086 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 216 of 254 SUCCESS (0
>> secs / 4.102 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 217 of 254 SUCCESS (0
>> secs / 4.114 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 218 of 254 SUCCESS (0
>> secs / 4.126 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 219 of 254 SUCCESS (0
>> secs / 4.137 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 220 of 254 SUCCESS (0
>> secs / 4.142 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 221 of 254 SUCCESS (0
>> secs / 4.146 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 222 of 254 SUCCESS (0
>> secs / 4.15 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 223 of 254 SUCCESS (0
>> secs / 4.154 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 224 of 254 SUCCESS (0
>> secs / 4.167 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 225 of 254 SUCCESS (0
>> secs / 4.175 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 226 of 254 SUCCESS (0
>> secs / 4.179 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 227 of 254 SUCCESS (0
>> secs / 4.184 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 228 of 254 SUCCESS (0
>> secs / 4.188 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 229 of 254 SUCCESS (0
>> secs / 4.192 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 230 of 254 SUCCESS (0
>> secs / 4.196 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 231 of 254 SUCCESS (0
>> secs / 4.2 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 232 of 254 SUCCESS (0
>> secs / 4.204 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 233 of 254 SUCCESS (0
>> secs / 4.208 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 234 of 254 SUCCESS (0
>> secs / 4.213 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 235 of 254 SUCCESS (0
>> secs / 4.217 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 236 of 254 SUCCESS (0
>> secs / 4.225 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0) the keyboard shortcuts
>> Shift+CTRL+Comma when there is not a query already running should comment
>> the line FAILED
>> Expected spy SqlEditorController.commentLineCode to have been
>> called.
>> regression/javascript/sqleditor/keyboard_shortcuts_spec.js:236:72
>> PhantomJS 2.1.1 (Linux 0.0.0): Executed 237 of 254 (1 FAILED) (0 secs /
>> 4.23 secs)
>> PhantomJS 2.1.1 (Linux 0.0.0) the keyboard shortcuts Shift+CTRL+Comma
>> when there is not a query already running should comment the line FAILED
>> Expected spy SqlEditorController.commentLineCode to have been
>> called.
>> regression/javascript/sqleditor/keyboard_shortcuts_spec.js:236:72
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0) the keyboard shortcuts
>> Shift+CTRL+Comma when there is not a query already running stops all event
>> propogation should cancel the bubble FAILED
>> Expected false to be true.
>> regression/javascript/sqleditor/keyboard_shortcuts_spec.js:320:40
>> regression/javascript/jasmine_capture_warnings_beforeall.js:94:9
>> PhantomJS 2.1.1 (Linux 0.0.0): Executed 238 of 254 (2 FAILED) (0 secs /
>> 4.236 secs)
>> PhantomJS 2.1.1 (Linux 0.0.0) the keyboard shortcuts Shift+CTRL+Comma
>> when there is not a query already running stops all event propogation
>> should cancel the bubble FAILED
>> Expected false to be true.
>> regression/javascript/sqleditor/keyboard_shortcuts_spec.js:320:40
>> regression/javascript/jasmine_capture_warnings_beforeall.js:94:9
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0) the keyboard shortcuts
>> Shift+CTRL+Comma when there is not a query already running stops all event
>> propogation should prevent the default behavior FAILED
>> Expected spy preventDefault to have been called.
>> regression/javascript/sqleditor/keyboard_shortcuts_spec.js:324:54
>> regression/javascript/jasmine_capture_warnings_beforeall.js:94:9
>> PhantomJS 2.1.1 (Linux 0.0.0): Executed 239 of 254 (3 FAILED) (0 secs /
>> 4.24 secs)
>> PhantomJS 2.1.1 (Linux 0.0.0) the keyboard shortcuts Shift+CTRL+Comma
>> when there is not a query already running stops all event propogation
>> should prevent the default behavior FAILED
>> Expected spy preventDefault to have been called.
>> regression/javascript/sqleditor/keyboard_shortcuts_spec.js:324:54
>> regression/javascript/jasmine_capture_warnings_beforeall.js:94:9
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0) the keyboard shortcuts
>> Shift+CTRL+Comma when there is not a query already running stops all event
>> propogation should stop event propagation FAILED
>> Expected spy stopPropagation to have been called.
>> regression/javascript/sqleditor/keyboard_shortcuts_spec.js:328:55
>> regression/javascript/jasmine_capture_warnings_beforeall.js:94:9
>> Expected spy stopImmediatePropagation to have been called.
>> regression/javascript/sqleditor/keyboard_shortcuts_spec.js:329:64
>> regression/javascript/jasmine_capture_warnings_beforeall.js:94:9
>> PhantomJS 2.1.1 (Linux 0.0.0): Executed 240 of 254 (4 FAILED) (0 secs /
>> 4.244 secs)
>> PhantomJS 2.1.1 (Linux 0.0.0) the keyboard shortcuts Shift+CTRL+Comma
>> when there is not a query already running stops all event propogation
>> should stop event propagation FAILED
>> Expected spy stopPropagation to have been called.
>> regression/javascript/sqleditor/keyboard_shortcuts_spec.js:328:55
>> regression/javascript/jasmine_capture_warnings_beforeall.js:94:9
>> Expected spy stopImmediatePropagation to have been called.
>> regression/javascript/sqleditor/keyboard_shortcuts_spec.js:329:64
>> regression/javascript/jasmine_capture_warnings_beforeall.js:94:9
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 241 of 254 (4 FAILED) (0
>> secs / 4.248 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 242 of 254 (4 FAILED) (0
>> secs / 4.252 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 243 of 254 (4 FAILED) (0
>> secs / 4.256 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 244 of 254 (4 FAILED) (0
>> secs / 4.26 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 245 of 254 (4 FAILED) (0
>> secs / 4.267 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 246 of 254 (4 FAILED) (0
>> secs / 4.272 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0) the keyboard shortcuts Shift+CTRL+/
>> when there is not a query already running should comment a block of code
>> FAILED
>> Expected spy SqlEditorController.commentBlockCode to have been
>> called.
>> regression/javascript/sqleditor/keyboard_shortcuts_spec.js:296:73
>> PhantomJS 2.1.1 (Linux 0.0.0): Executed 247 of 254 (5 FAILED) (0 secs /
>> 4.276 secs)
>> PhantomJS 2.1.1 (Linux 0.0.0) the keyboard shortcuts Shift+CTRL+/ when
>> there is not a query already running should comment a block of code FAILED
>> Expected spy SqlEditorController.commentBlockCode to have been
>> called.
>> regression/javascript/sqleditor/keyboard_shortcuts_spec.js:296:73
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 248 of 254 (5 FAILED) (0
>> secs / 4.28 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 249 of 254 (5 FAILED) (0
>> secs / 4.284 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 250 of 254 (5 FAILED) (0
>> secs / 4.288 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 251 of 254 (5 FAILED) (0
>> secs / 4.292 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 252 of 254 (5 FAILED) (0
>> secs / 4.296 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 253 of 254 (5 FAILED) (0
>> secs / 4.301 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 254 of 254 (5 FAILED) (0
>> secs / 4.305 secs)
>> [1A [2KPhantomJS 2.1.1 (Linux 0.0.0): Executed 254 of 254 (5 FAILED)
>> (4.359 secs / 4.305 secs)
>> ERROR: Error detected when running the Jasmine tests.
>> ERROR: Error detected when running the Jasmine tests.
>> Build step 'Execute shell' marked build as failure
>>
>>
>
diff --git a/web/regression/javascript/sqleditor/keyboard_shortcuts_spec.js
b/web/regression/javascript/sqleditor/keyboard_shortcuts_spec.js
index d64a504..9f89482 100644
--- a/web/regression/javascript/sqleditor/keyboard_shortcuts_spec.js
+++ b/web/regression/javascript/sqleditor/keyboard_shortcuts_spec.js
@@ -14,9 +14,9 @@ describe('the keyboard shortcuts', () => {
F5_KEY = 116,
F7_KEY = 118,
F8_KEY = 119,
- COMMA_KEY = 188,
PERIOD_KEY = 190,
- FWD_SLASH_KEY = 191;
+ FWD_SLASH_KEY = 191,
+ isMacSystem = window.navigator.platform.search('Mac') != -1;
let sqlEditorControllerSpy;
let event;
@@ -164,12 +164,13 @@ describe('the keyboard shortcuts', () => {
});
});
- describe('Shift+CTRL+Comma', () => {
+ describe('inlineComment', () => {
describe('when there is not a query already running', () => {
beforeEach(() => {
+ event.metaKey = isMacSystem;
event.shiftKey = true;
- event.ctrlKey = true;
- event.which = COMMA_KEY;
+ event.ctrlKey = !isMacSystem;
+ event.which = FWD_SLASH_KEY;
keyboardShortcuts.processEvent(sqlEditorControllerSpy, event);
});
@@ -182,9 +183,9 @@ describe('the keyboard shortcuts', () => {
describe('when the query is already running', () => {
it('does nothing', () => {
- event.shiftKey = true;
- event.ctrlKey = true;
- event.which = COMMA_KEY;
+ event.shiftKey = isMacSystem;
+ event.ctrlKey = !isMacSystem;
+ event.which = FWD_SLASH_KEY;
sqlEditorControllerSpy.isQueryRunning.and.returnValue(true);
keyboardShortcuts.processEvent(sqlEditorControllerSpy, event);
@@ -194,11 +195,12 @@ describe('the keyboard shortcuts', () => {
});
});
- describe('Shift+CTRL+Period', () => {
+ describe('inlineUncomment', () => {
describe('when there is not a query already running', () => {
beforeEach(() => {
+ event.metaKey = isMacSystem;
event.shiftKey = true;
- event.ctrlKey = true;
+ event.ctrlKey = !isMacSystem;
event.which = PERIOD_KEY;
keyboardShortcuts.processEvent(sqlEditorControllerSpy, event);
});
@@ -212,9 +214,10 @@ describe('the keyboard shortcuts', () => {
describe('when the query is already running', () => {
it('does nothing', () => {
+ event.metaKey = isMacSystem;
event.shiftKey = true;
- event.ctrlKey = true;
- event.which = COMMA_KEY;
+ event.ctrlKey = !isMacSystem;
+ event.which = PERIOD_KEY;
sqlEditorControllerSpy.isQueryRunning.and.returnValue(true);
keyboardShortcuts.processEvent(sqlEditorControllerSpy, event);
@@ -224,11 +227,11 @@ describe('the keyboard shortcuts', () => {
});
});
- describe('Shift+CTRL+/', () => {
+ describe('blockComment', () => {
describe('when there is not a query already running', () => {
beforeEach(() => {
- event.shiftKey = true;
- event.ctrlKey = true;
+ event.metaKey = isMacSystem;
+ event.ctrlKey = !isMacSystem;
event.which = FWD_SLASH_KEY;
keyboardShortcuts.processEvent(sqlEditorControllerSpy, event);
});
@@ -242,8 +245,8 @@ describe('the keyboard shortcuts', () => {
describe('when the query is already running', () => {
it('does nothing', () => {
- event.shiftKey = true;
- event.ctrlKey = true;
+ event.metaKey = isMacSystem;
+ event.ctrlKey = !isMacSystem;
event.which = FWD_SLASH_KEY;
sqlEditorControllerSpy.isQueryRunning.and.returnValue(true);
