On Tue, Aug 22, 2017 at 6:07 PM, Dave Page <dp...@pgadmin.org> wrote:
> > > On Tue, Aug 22, 2017 at 1:30 PM, Surinder Kumar < > surinder.ku...@enterprisedb.com> wrote: > >> Hi >> >> *Issue:* >> >> The user seems to enter sometimes paths with quotes and sometimes add >> spaces which lead to failure of Backup, Restore or Maintenance utility. >> >> *Changes:* >> >> - Added a note in help string `Note: Don't add quote(s) or space(s) >> before or after the path.` >> >> - Remove whitespace before/after the value before it gets saved. >> >> Please find attached patch and review. >> > > I wonder if the more appropriate fix here would be to add a new setting > type (perhaps two, one for directory and one for file), which is rendered > with a browse button in the prefs panel, and includes real validation. > Yes, the suggested way is a better way. I will check what changes we have to made in preferences code to add support for new setting type and validations. > > Stripping spaces and warning about quotes seems like it's just kicking the > basic problem down the road a few feet. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
