Code looks good to me. Thanks patch applied. On Mon, Sep 11, 2017 at 5:40 PM, Akshay Joshi <akshay.jo...@enterprisedb.com > wrote:
> > > On Mon, Sep 11, 2017 at 5:34 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Akshay, can you review/commit this please? >> > > Sure Dave. > >> >> Thanks. >> >> On Mon, Sep 11, 2017 at 10:38 AM, Teng Zhang <tezh...@pivotal.io> wrote: >> >>> Hi Hackers, >>> >>> Attached is a patch that makes SQL editor show syntax highlighting with >>> Greenplum keywords. >>> >>> - Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql" >>> - Use "x-gpsql" mode for sql editor when connecting database is greenplum >>> - No behavior change to pg and ppas, still use "x-pgsql" >>> >>> Regards, >>> Hao Wang & Teng Zhang >>> >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > -- *Akshay Joshi* *Principal Software Engineer * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
