Re: [pgAdmin4][Patch]: To make error message uniform for Create schema action

[Murtuza Zabuawala]

Hi,

PFA updated.

On Thu, Nov 16, 2017 at 5:12 PM, Dave Page <dp...@pgadmin.org> wrote:

>
>
> On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawala <
> murtuza.zabuaw...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> PFA minor patch to make error message uniform for 'Create schema' in both
>> query tool and create schema dialog.
>> RM#2094
>>
>
> The error message is definitely an improvement, but the dialogue title
> needs work:
>
> Error saving properties: GONE
>
> Why does it have : GONE on the end? That seems unhelpful.
>
​That's coming from ajax statusText
<https://developer.mozilla.org/en-US/docs/Web/API/Response/statusText>, I
thought it was intended.

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

diff --git 
a/web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py 
b/web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py
index 04d2432..49c953c 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/__init__.py
@@ -580,8 +580,7 @@ It may have been removed by another user.
                 return make_json_response(
                     status=410,
                     success=0,
-                    errormsg=res + '\n' +
-                             'Operation failed while running create statement'
+                    errormsg=res
                 )
 
             # we need oid to to add object in tree at browser,
diff --git a/web/pgadmin/browser/static/js/node.js 
b/web/pgadmin/browser/static/js/node.js
index 9a5b894..2beadf9 100644
--- a/web/pgadmin/browser/static/js/node.js
+++ b/web/pgadmin/browser/static/js/node.js
@@ -1153,10 +1153,8 @@ define(
               error: function(m, jqxhr) {
                 Alertify.pgNotifier(
                   "error", jqxhr,
-                  S(
-                    gettext("Error saving properties: %s")
-                    ).sprintf(jqxhr.statusText).value()
-                  );
+                  gettext("Error saving properties")
+                );
 
                 // Hide progress cursor
                 $('.obj_properties').removeClass('show_progress');
diff --git a/web/pgadmin/tools/grant_wizard/static/js/grant_wizard.js 
b/web/pgadmin/tools/grant_wizard/static/js/grant_wizard.js
index 61b0eda..4898f7f 100644
--- a/web/pgadmin/tools/grant_wizard/static/js/grant_wizard.js
+++ b/web/pgadmin/tools/grant_wizard/static/js/grant_wizard.js
@@ -1089,10 +1089,8 @@ define([
                         error: function(m, jqxhr) {
                           alertify.pgNotifier(
                             "error", jqxhr,
-                            S(
-                              gettext("Error saving properties: %s")
-                              ).sprintf(jqxhr.statusText).value()
-                            );
+                            gettext("Error saving properties")
+                          );
 
                             // Release wizard objects
                             self.releaseObjects();