On Mon, Nov 27, 2017 at 4:13 PM, Dave Page <[email protected]> wrote:
>
>
> On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi <
> [email protected]> wrote:
>
>>
>>
>> On Mon, Nov 27, 2017 at 2:59 PM, Dave Page <[email protected]> wrote:
>>
>>>
>>>
>>> On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi <
>>> [email protected]> wrote:
>>>
>>>>
>>>>
>>>> On Mon, Nov 27, 2017 at 2:20 PM, Dave Page <[email protected]> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> On Fri, Nov 24, 2017 at 3:21 PM, Dave Page <[email protected]> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> On Thu, Nov 23, 2017 at 2:58 PM, Dave Page <[email protected]>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Hi
>>>>>>>>>
>>>>>>>>> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> Please find the attached patch to fix RM #2859: Can't create new
>>>>>>>>>> user.
>>>>>>>>>>
>>>>>>>>>> The "User Management" dialogue footer was overlapping the
>>>>>>>>>> back-grid table which has been fixed.
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> If my screen is too small, it now looks like the attached
>>>>>>>>> screenshot, which is really quite ugly.
>>>>>>>>>
>>>>>>>>> If we don't leave the bottom blank space then in case of error the
>>>>>>>> error-message will shown on the grid itself and user can't perform any
>>>>>>>> task.
>>>>>>>> Please refer the attached screen-shot for the same.
>>>>>>>>
>>>>>>>
>>>>>>> Right, but we also can't have that space left blank like that. Can't
>>>>>>> we extend the scroll range of the grid? In other words, always include
>>>>>>> space for an extra row or so, so it can scroll above the error message,
>>>>>>> when, and only when a message is shown?
>>>>>>>
>>>>>>>
>>>>>> Please find the attached screen-shot, If we always include an extra
>>>>>> row.
>>>>>> Suggestion please.
>>>>>>
>>>>>
>>>>> I think that's much better, though still not ideal. What if we made
>>>>> the error messages closable like other notifications?
>>>>>
>>>>> The error-messages in pgAdmin 4 are not closable, so it will not go
>>>> with the flow.
>>>>
>>>
>>> I meant to do it globally.
>>>
>>> Should I create the separate case for this?
>>
>
> No, I don't think there's any need for that.
>
> Does it seem like it would solve the problem appropriately?
>
>
It would lead us to more complexity
1. How can we keep track of the closed error messages for multiple fields?
2. We have validated backbone model on focus out/change, so we need to
change the basic error model.
I have attached the patch for the RM #2859.
Thanks,
Khushboo
--
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
diff --git a/web/pgadmin/static/css/bootstrap.overrides.css b/web/pgadmin/static/css/bootstrap.overrides.css
index b894021..6e3e580 100755
--- a/web/pgadmin/static/css/bootstrap.overrides.css
+++ b/web/pgadmin/static/css/bootstrap.overrides.css
@@ -1218,6 +1218,11 @@ height: calc(100% - 35px);
line-height: 16px;
}
+.user_management table tbody tr.blank_row {
+ visibility: hidden;
+ height: 35px;
+}
+
.pg-panel-statistics-container >table.backgrid.table-bordered {
border: 0px;
}
diff --git a/web/pgadmin/tools/user_management/static/js/user_management.js b/web/pgadmin/tools/user_management/static/js/user_management.js
index ffdf8b2..4ae738c 100644
--- a/web/pgadmin/tools/user_management/static/js/user_management.js
+++ b/web/pgadmin/tools/user_management/static/js/user_management.js
@@ -392,8 +392,8 @@ define([
prepare: function() {
var self = this,
footerTpl = _.template([
- '<div class="pg-prop-footer">',
- '<div class="pg-prop-status-bar" style="visibility:hidden">',
+ '<div class="pg-prop-footer" style="visibility:hidden;">',
+ '<div class="pg-prop-status-bar">',
'<div class="media error-in-footer bg-red-1 border-red-2 font-red-3 text-14">',
'<div class="media-body media-middle">',
'<div class="alert-icon error-icon">',
@@ -405,8 +405,7 @@ define([
'</div>',
'</div>',
'</div>'].join("\n")),
- $footer = $(footerTpl()),
- $statusBar = $footer.find('.pg-prop-status-bar'),
+ $statusBar = $(footerTpl()),
UserRow = Backgrid.Row.extend({
userInvalidColor: "lightYellow",
@@ -558,7 +557,7 @@ define([
this.$content = $("<div class='user_management object subnode'></div>").append(
headerTpl(data)).append($gridBody
- ).append($footer);
+ ).append($statusBar);
$(this.elements.body.childNodes[0]).addClass(
'alertify_tools_dialog_backgrid_properties');
@@ -569,7 +568,12 @@ define([
$('.search_users').append(
userFilter(userCollection).render().el);
- userCollection.fetch();
+ userCollection.fetch({
+ success: function() {
+ // Add blank hidden row
+ $gridBody.find("table tbody").append('<tr class="blank_row"></tr>');
+ }
+ });
this.$content.find('button.add').first().click(function(e) {
e.preventDefault();
