+pgadmin-hackers -- *Harshal Dhumal* *Sr. Software Engineer*
EnterpriseDB India: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Dec 14, 2017 at 5:26 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi, > > Please find attached patch for various data type test cases. > > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Mon, Dec 11, 2017 at 5:24 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> >> -- >> *Harshal Dhumal* >> *Sr. Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Sat, Dec 9, 2017 at 12:06 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Sat, Dec 9, 2017 at 11:50 AM, Harshal Dhumal < >>> harshal.dhu...@enterprisedb.com> wrote: >>> >>>> >>>> On Sat, Dec 9, 2017 at 11:30 AM, Dave Page <dp...@pgadmin.org> wrote: >>>> >>>>> Hi >>>>> >>>>> Yeah, that one is in my list to work on. Have you specifically tested >>>>> it with enum types (not enum[])? >>>>> >>>> >>>> Yes. >>>> >>> >>> @Harshal, >>> >>> Can you add multidimensional array, enum types into feature test >>> (pg_datatype_validation_test.py) ? >>> >> >> I think I need to add test cases for all array data types not just enum >> types since fix was not targeted for any particular data type. >> >> >>> >>> [image: Inline image 3] >>>> >>>> >>>> >>>>> >>>>> On Sat, Dec 9, 2017 at 5:55 AM, Harshal Dhumal < >>>>> harshal.dhu...@enterprisedb.com> wrote: >>>>> >>>>>> Hi Dave, >>>>>> >>>>>> Recently I sent a patch >>>>>> <https://www.postgresql.org/message-id/CAFiP3vzj6t2QuhkWy-sHnpcQB4tiq%2BK6gqLOVQkkcOuBtksvfw%40mail.gmail.com> >>>>>> regarding multidimensional array representation issue. >>>>>> In that patch I have reworked about how multidimensional (1 dimension >>>>>> to n dimension) >>>>>> array data should be represented in grid. >>>>>> Also this patch covers almost all the array data types including >>>>>> composite array data types like >>>>>> int8range[], enum[], inet[], cidr[], macaddr[], uuid[], xml[], bit[], >>>>>> varbit[] and so on. >>>>>> >>>>>> Please review the patch and let me know if any thing needs to be >>>>>> included in this patch. >>>>>> >>>>>> Thanks, >>>>>> >>>>>> >>>>>> -- >>>>>> *Harshal Dhumal* >>>>>> *Sr. Software Engineer* >>>>>> >>>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> On Sat, Dec 9, 2017 at 10:45 AM, Dave Page <dp...@pgadmin.org> wrote: >>>>>> >>>>>>> Murtuza, can you investigate please? >>>>>>> >>>>>>> Thanks! >>>>>>> >>>>>>> On Fri, Dec 8, 2017 at 8:08 PM, Bartosz Dmytrak <bdmyt...@gmail.com> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> According to documentation: https://www.postgresql.org/doc >>>>>>>> s/current/static/functions-enum.html when I execute SELECT >>>>>>>> enum_range(null::rainbow) then output should look like this: >>>>>>>> {red,orange,yellow,green,blue,purple} >>>>>>>> >>>>>>>> But in pgAdmin output looks like this: >>>>>>>> {{,r,e,d,,,o,r,a,n,g,e,,,y,e,l,l,o,w,,,g,r,e,e,n,,,b,l,u,e,,,p,u,r,p,l,e,}}. >>>>>>>> When you click on the field, popup window shows correct value. I’ve >>>>>>>> double >>>>>>>> checked it in psql, and output is correct. I think it could be >>>>>>>> considered >>>>>>>> as bug in pgAdmin >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> PgAdmin details: >>>>>>>> >>>>>>>> *Version *2.0 >>>>>>>> >>>>>>>> *Python Version *2.7.13 (v2.7.13:a06454b1afa1, Dec 17 2016, >>>>>>>> 20:42:59) [MSC v.1500 32 bit (Intel)] >>>>>>>> >>>>>>>> *Flask Version *0.12.2 >>>>>>>> >>>>>>>> *Application Mode *Desktop >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Pg Version: 10.1 >>>>>>>> >>>>>>>> Regardless this one, many thanks for your great job pgAdmin Team! >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Best regards, >>>>>>>> >>>>>>>> *Bartosz Dmytrak* >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Dave Page >>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>> Twitter: @pgsnake >>>>>>> >>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>>> >>> >> >
