Hello Murtuza, I believe it is a bit too much to have a feature test for this. A unit test around the function in question could have sufficed, specially because we are not yet running them in Jenkins, but I think it is ok. So I review the patch, applied and run our CI and everything is green. So I believe this patch is good to be merged.
Thanks Joao On Fri, Feb 16, 2018 at 5:28 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA updated patch, which includes feature test to test the scenario going > forward. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Thu, Feb 15, 2018 at 7:53 PM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Sure, will do that. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Thu, Feb 15, 2018 at 7:34 PM, Joao De Almeida Pereira < >> jdealmeidapere...@pivotal.io> wrote: >> >>> Hello Murtuza, >>> Just reviewed your patch, and it looks good. >>> Do you think you can wrap some tests around this behavior to ensure it >>> doesn't happen again in the future? >>> >>> Thanks >>> Joao >>> >>> On Thu, Feb 15, 2018 at 8:34 AM Murtuza Zabuawala < >>> murtuza.zabuaw...@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> PFA patch to fix the issue user was not able to insert new row in the >>>> table via 'view data' if the PK is in capital letters. >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >> >
