On Mon, Mar 5, 2018 at 8:12 AM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:

> Hi,
> PFA patch to disable Gravatar image in Server mode.
> Requirments & Issues:
> - For security reasons.
> - For systems which do not have internet access.
> - Hangs pgAdmin4 while loading the page if connection has no internet
> access (as described in the ticket)

If I run with the Gravatar disabled, then I get the following regression

FAIL: runTest (pgadmin.browser.tests.test_login.LoginTestCase)
Traceback (most recent call last):
  File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/tests/test_login.py",
line 93, in runTest
    self.assertTrue(self.respdata in response.data.decode('utf8'))
AssertionError: False is not true


It's fine when Gravatar is enabled (and the rest of the patch does too).

Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Reply via email to