Thanks - applied. On Wed, Mar 7, 2018 at 4:30 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote:
> > > On Tue, Mar 6, 2018 at 8:35 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Khushboo, >> >> All tests pass on CI, and the code looks good. The only issue that I >> found was the line: >> os.path.dirname(os.path.realpath(__file__)) + "/../templates" >> >> that will not work on windows. >> So I updated your patch with the change and it should be ready to merge. >> >> Thanks Joao. > > Thanks >> Joao >> >> On Tue, Mar 6, 2018 at 7:33 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi Joao, >>> >>> Thanks for reviewing. >>> >>> On Thu, Mar 1, 2018 at 8:06 PM, Joao De Almeida Pereira < >>> jdealmeidapere...@pivotal.io> wrote: >>> >>>> Hello Kushboo, >>>> >>>> Can we add some Unit test to ensure this does not happen again? >>>> >>>> Please find the attached patch with the unit tests. >>> >>>> Thanks >>>> Joao >>>> >>>> Thanks, >>> Khushboo >>> >>>> On Thu, Mar 1, 2018 at 2:28 AM Khushboo Vashi < >>>> khushboo.va...@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> >>>>> Please find the attached patch to fix RM # 3135 - [Web based] Syntax >>>>> error displayed when user try to insert data on table where primray key is >>>>> in captial letters and table contains OIDS >>>>> >>>>> Thanks, >>>>> Khushboo >>>>> >>>> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
