On Fri, Mar 23, 2018 at 11:27 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote:
> On Fri, Mar 23, 2018 at 3:21 PM, Dave Page <dp...@pgadmin.org> wrote: > >> >> >> On Fri, Mar 23, 2018 at 5:43 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Thu, Mar 22, 2018 at 3:42 PM, Dave Page <dp...@pgadmin.org> wrote: >>> >>>> >>>> >>>> On Thu, Mar 22, 2018 at 9:58 AM, Khushboo Vashi < >>>> khushboo.va...@enterprisedb.com> wrote: >>>> >>>>> >>>>> >>>>> On Thu, Mar 22, 2018 at 3:20 PM, Dave Page <dp...@pgadmin.org> wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> On Thu, Mar 22, 2018 at 9:25 AM, Khushboo Vashi < >>>>>> khushboo.va...@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Dave, >>>>>>> >>>>>>> On Wed, Mar 21, 2018 at 9:05 PM, Dave Page <dp...@pgadmin.org> >>>>>>> wrote: >>>>>>> >>>>>>>> We've run into a number of unexpected issues with the v3.0 release >>>>>>>> that I think we need to resolve before moving forwards. For the time >>>>>>>> being, >>>>>>>> only patches critical to fix these issues should be committed. >>>>>>>> >>>>>>>> I'll try to look at 1, though I do have another deadline I need to >>>>>>>> meet. >>>>>>>> Akshay, can you look at 2 please? >>>>>>>> Fahar is already looking at 3. >>>>>>>> Khushboo, can you look at 4 please? >>>>>>>> >>>>>>>> Thanks all. >>>>>>>> >>>>>>>> 1) There is no longer a system tray in Gnome 3.26 and later, and >>>>>>>> thus the runtime won't initialise in Fedora 27 and later. We need an >>>>>>>> alternative for this, either a tray replacement that the RPM can >>>>>>>> depend on, >>>>>>>> or better yet, support whatever it is Gnome expect such apps to use >>>>>>>> these >>>>>>>> days. >>>>>>>> >>>>>>>> 2) Starting a second instance of the app bundle on Mac doesn't >>>>>>>> always open a new pgAdmin window as it should. It works fine in the >>>>>>>> debugger, or if you start the app with a command like: >>>>>>>> "/Applications/pgAdmin\ 4.app/Contents/MacOS/pgAdmin4". It doesn't >>>>>>>> work if you double-click the appbundle or use a command like "open >>>>>>>> /Applications/pgAdmin\ 4.app" >>>>>>>> >>>>>>>> 3) Fahar saw a crash on Windows 7. I couldn't reproduce this on my >>>>>>>> copy, but apparently his is a fresh installation. >>>>>>>> >>>>>>>> 4) On my Windows 7 machine, after running a backup I get no status >>>>>>>> window, and see the following in the logs: >>>>>>>> >>>>>>>> >>>>>>> We have tried to reproduce this issue on Windows 7 and Windows 8, >>>>>>> but couldn't reproduce it, It is working fine on both the environments. >>>>>>> Can you please provide the options which you have selected while >>>>>>> taking a backup? >>>>>>> >>>>>> >>>>>> They were all the default options - I just selected a database, >>>>>> right-clicked to select backup, and entered a filename. >>>>>> >>>>>> >>>>> With the default options, it is working fine. >>>>> >>>> >>>> Can you see any way in which the exception below could conceivably >>>> happen? Perhaps if run on a system that has process logs from an older >>>> version of pgAdmin? >>>> >>>> >>> Not sure as this issue was fixed by Ashesh 1 year back as per git logs. >>> >> >> Well the VM I was testing in did have some process logs from over a year >> ago. Removing them, and truncating the process table in the sqlite DB seems >> to have resolved the issue. >> >> So, I think that's something to watch for if people have backup issues >> and have used older versions of pgAdmin... >> > Should we have a job to purge them on a timely basis? (Of course - > configurable) > Hmm, not sure if it's worth it. We should make sure that future changes in that code can cope with older format logs and DB entries though. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
