Hi Dave, PFA updated patch, I've renamed it to query_tool_http_error_handler.js & query_tool_http_error_handler_spec.js respectively.
-- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Tue, Apr 3, 2018 at 7:43 PM, Dave Page <dp...@pgadmin.org> wrote: > HI > > On Tue, Apr 3, 2018 at 12:27 PM, Murtuza Zabuawala <murtuza.zabuawala@ > enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to extract the common code from query tool to handle ajax >> errors & connection handling, Also added unit tests around extracted code. >> > > Looks good to me, except, I wonder if we should rename > is_new_transaction_required.js/is_new_transaction_required_spec.js to > something a little more generic; maybe conn_tx_handler_funcs.js? Not sure I > like that though. > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
RM_3235_v1.diff
Description: Binary data
