Can you rebase this please? On Wed, Mar 28, 2018 at 8:19 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote:
> Hi Dave, > > Please find updated patch with following changes, > - Combined Filter and Data sorting together same as pgAdmin3. > - Extracted model into separate file > - Change the colour of filter button from orange to blue. > - Updated docs and screenshot. > > @Joao, > Could you please provide any reference for learning more about jasmine > test framework? > > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Wed, Mar 28, 2018 at 6:07 AM, Robert Eckhardt <reckha...@pivotal.io> > wrote: > >> >> >> On Tue, Mar 27, 2018 at 9:54 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> >>> >>> On Tue, Mar 27, 2018 at 7:06 PM, Robert Eckhardt <reckha...@pivotal.io> >>> wrote: >>> >>>> >>>> >>>> On Tue, Mar 27, 2018 at 6:25 AM, Murtuza Zabuawala < >>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>> >>>>> On Tue, Mar 27, 2018 at 3:13 PM, Dave Page <dp...@pgadmin.org> wrote: >>>>> >>>>>> >>>>>> >>>>>> On Mon, Mar 26, 2018 at 9:26 PM, Robert Eckhardt < >>>>>> reckha...@pivotal.io> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Mon, Mar 26, 2018 at 2:07 PM, Joao De Almeida Pereira < >>>>>>> jdealmeidapere...@pivotal.io> wrote: >>>>>>> >>>>>>>> Hi Hackers, >>>>>>>> >>>>>>>> @Murtuza: The patch codewise looks good. Nice to see that we are >>>>>>>> using axios instead of jquery ajax calls and that there is some >>>>>>>> coverage >>>>>>>> for the change. >>>>>>>> Nevertheless the Javascript testing looks a bit slim and could be >>>>>>>> improved. Also the DataSorting class could have some other member >>>>>>>> functions >>>>>>>> like the model validation could be extracted out so that it is easily >>>>>>>> tested. >>>>>>>> >>>>>>>> >>>>>>>> @Hackers: This was how we tried to test this feature: >>>>>>>> 1 - Started pgAdmin >>>>>>>> 2 - Opened the query tool for a specific server >>>>>>>> 3 - Executed a SQL statment >>>>>>>> 4 - Pressed the column header to try to order, nothing happened >>>>>>>> 5 - Right clicked the column header to see if it was there the >>>>>>>> option, nothing >>>>>>>> >>>>>>>> This is the behavior that we were expecting, not to have to open >>>>>>>> Data View and then press the icon that is not even near the grid in >>>>>>>> order >>>>>>>> to sort the column. Is this really the way we want people to use the >>>>>>>> grid >>>>>>>> in pgAdmin? Should it be more intuitive? >>>>>>>> >>>>>>> >>>>>>> Have we considered making the grid behave more like excel or other >>>>>>> grids? I think that having the ascending and descending inside the >>>>>>> column >>>>>>> header, we could similarly provide filtering. Something that would give >>>>>>> users a more intuitive place to look. >>>>>>> >>>>>> >>>>>> Doing the sorting via header clicks is convenient but very >>>>>> restrictive. How do you specify multiple columns to sort by for example? >>>>>> The current design allows you to select columns and the sort order as you >>>>>> see fit. >>>>>> >>>>> >>>> Honestly I'm not sold on my idea, I was just proposing an alternative >>>> in an effort to start a discussion about the user experience. Ideally what >>>> I'd like to see, maybe this happened, is some user research. When we >>>> initial worked on refactoring the results grid we made a bunch of changes. >>>> One of the things we intended to do was to follow up to see how people were >>>> using the grid now so that we could better understand how it was now being >>>> used in order to design and implement features just like this. Clearly we >>>> haven't gotten there yet. >>>> >>>> >>>>> >>>>> Another reason we can't use that because w >>>>> e have already occupied that behaviour for selecting entire column >>>>> when user clicks on header. >>>>> As Dave suggested, I will be merging it with filter dialog meaning it >>>>> will be accessible via direct button on toolbar & keyboard shortcut. >>>>> >>>>> >>>> >>>> How are users currently interacting with that filter dialog? >>>> >>> >>> By clicking on the toolbar button as well as keyboard shortcut. >>> >>> >>> >>> >>> >> >> Sorry I wasn't clear. My question was more along the lines of, do we >> know if people are using the filter functionality? What kind of filters >> are people using? What do they like about it? What do they wish they could >> do above and beyond sorting, etc. >> > I have not done any data gathering from users so I can't comment on your > queries. > but a > s far as I understood from the feature requests that most of the users > expect to have functionality which will allow then to sort columns as it > was in pgAdmin3. > > > >> -- Rob >> >> >>> >>>> What I'm suggesting is that we understand how users want to interact >>>> with their results, be those the results of a query or a table view, then >>>> we can design something that meets those needs. I agree that changing the >>>> column selection behavior isn't desirable, however, I also feel like >>>> providing the best user experience is better than holding onto a particular >>>> feature implementation. >>>> >>>> >>>> >>> >>>> -- Rob >>>> >>>> >>>>> >>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>> >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
