Thanks, applied. On Tue, Apr 10, 2018 at 6:57 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote:
> Thanks for reviewing Joao. > > Yeah missed to run tests. I assumed its just a SQL formatting it wouldn't > hurt anything but I was wrong :) > Here's updated patch. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Tue, Apr 10, 2018 at 8:18 PM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hi Murtuza, >> Looks like the tests are failing due to this change. >> I also got some strange result on the linter, but I believe it is >> something related to this machine. >> >> Thanks >> Joao >> >> On Tue, Apr 10, 2018 at 6:20 AM Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> A minor fix for explain functionality. >>> >>> *Issue:* Due to multiline explain options in the SQL template >>> CodeMirror was failing to highlight the exact line of error. >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
