Re: [pgAdmin4][Patch]: Fixed RM #3295 - Shortcut key conflict issue

[Aditya Toshniwal]

Hi Hackers,

PFA updated patch for RM#3295. The patch is to fix the issue in firefox
also.
Kindly review. Please try in firefox also.

Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

On Wed, May 9, 2018 at 6:58 PM, Dave Page <dp...@pgadmin.org> wrote:

> Thanks, applied.
>
> On Wed, May 9, 2018 at 2:10 PM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix RM #3295: Shortcut key conflict
>> issue
>>
>> After opening the debugger, the shift+alt+o short-cut opens the Object
>> menu as well as perform the step over to the debugger. This issue has been
>> fixed in this patch.
>>
>> Thanks,
>> Khushboo
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

diff --git a/web/pgadmin/tools/debugger/static/js/direct.js b/web/pgadmin/tools/debugger/static/js/direct.js
index b9cb2ec..42b2408 100644
--- a/web/pgadmin/tools/debugger/static/js/direct.js
+++ b/web/pgadmin/tools/debugger/static/js/direct.js
@@ -1850,8 +1850,13 @@ define([
         self.docker.off(wcDocker.EVENT.LOADED);
         // Register the callback when user set/clear the breakpoint on gutter area.
         self.editor.on('gutterClick', self.onBreakPoint.bind(self), self);
-        // Set focus to the debugger container
-        self.$container.focus();
+        /* Set focus to the debugger container
+         * Focus does not work in firefox without tabindex attr
+         * so, setting focus to parent of $container which is #container
+         */
+        if(self.docker.$container){
+          self.docker.$container.parent().focus();
+        }
       };
 
       self.docker.startLoading(gettext('Loading...'));