Hi Hackers, PFA updated patch. The sqleditor change is sent separately and removed from current patch as suggested. The test cases were running fine when the module was specified using --pkg but were failing in complete run. Fixed that.
Kindly review. Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB Software Solutions | Pune "Don't Complain about Heat, Plant a tree" On Tue, Jun 5, 2018 at 10:15 AM, Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi > > On Tue, Jun 5, 2018 at 1:08 AM, Joao De Almeida Pereira < > jdealmeidapere...@pivotal.io> wrote: > >> Hello Aditya, >> >>> >>> >>> There is no change related to notifications in this patch. >>> The below code is minor fix related to connection status of sql editor. >>> Can you please share the code snippet if it is not the below. >>> >>> - # Check for the asynchronous notifies statements. >>> - conn.check_notifies(True) >>> - notifies = conn.get_notifies() >>> + if status is not None: >>> + # Check for the asynchronous notifies statements. >>> + conn.check_notifies(True) >>> + notifies = conn.get_notifies() >>> >>> >> This is a minor fix, but is it related to querying SQL_ASCII database? >> > No its not. It is something I found when I was working on SQL_ASCII > related changes. > Well then, will send a separate patch for it. > >> >> Thanks >> Victoria && Joao >> > >
RM3289.patch
Description: Binary data
