Hi

On Mon, Jun 25, 2018 at 1:23 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:

> Hi,
>
> Please find the attached patch for RM #3309 - Backup does not work with
> --format=d.
>
> Fixes in the patch :
>
> 1. Format = directory fix for Backup and Restore utilities
> 2. Test cases for format = directory
> 2. File manager fix - The selected directory was not properly populated in
> the text box
>

The patch disables the file picker button if you select Directory format.
This seems like poor behaviour; I think we need to modify the dialogue to
allow a directory to be selected.


> 3. Refactoring of File manager JS file
>

That's somewhat more readable. Can we add tests?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Reply via email to