Hi Dave, On Wed, Jul 11, 2018 at 4:15 PM, Dave Page <dp...@pgadmin.org> wrote:
> > > On Wed, Jul 11, 2018 at 8:03 AM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Please find the attached updated patch with PEP8 fixes. >> >> On Wed, Jul 11, 2018 at 11:18 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix #3191 : Debug option is not >>> working. >>> >>> Issues fixed: >>> >>> 1. EPAS packages' function/procedure does not honour INOUT arguments, it >>> converts INOUT to OUT. >>> >>> 2. Packages' functions and procedures are not getting listed in their >>> respected nodes in some scenarios like procedure having INOUT argument and >>> function with void return type >>> >>> 3. The Reverse engineering SQL is not correct for Packages' >>> functions/procedures >>> >>> 4. In case of INOUT argument, debugger asks for mendatory input which >>> should not. >>> >> > Hi > > Not sure if this is a result of your patch or not, but I'm seeing a > failure if I debug a procedure, then click run to debug it again in the > same debugger panel. The parameters dialogue opens, but nothing happens > when it's closed. Can you check please? > > This is working fine for me with/without my patch on PG 11. > This is on PG 11: > > -- PROCEDURE: public.dummy_proc(integer) > > -- DROP PROCEDURE public.dummy_proc(integer); > > CREATE OR REPLACE PROCEDURE public.dummy_proc( > id integer) > LANGUAGE 'plpgsql' > > AS $BODY$BEGIN > raise notice 'id is %', id; > END;$BODY$; > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > Thanks, Khushboo
