Hi Dave, On Tue, Sep 25, 2018 at 12:15 AM Dave Page <dp...@pgadmin.org> wrote:
> Hi > On Mon, Sep 24, 2018 at 2:05 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached updated patch. >> >> Feature Details: >> - The current tree state as well as the previous will be stored in the >> sqlite database. >> - The time interval to store the tree state is configurable via >> preferences and the default is 30 secs. >> -1 can be used to stop the tree saving functionality, >> - Jasmine test cases are included. >> >> Thanks, >> Khushboo >> > > This is looking good, however there are a couple of cases where I think > it's not quite working as I would expect: > > 1) As soon as the user opens pgAdmin, the tree state should be restored. > > As per our initial discussion, we have decided that once the user connects / expands the server, then we will restore that server state. *"If the user has switched network that may cause a whole bunch of connection failures after some period of time. Perhaps we should only restore when opening a particular server." * 2) If a database or server is disconnected, I would expect it's state to be > stored. When it is explicitly re-connected by the user, the state should be > restored. > > This is already implemented and working. Am I missing any particular scenario? > I think that covers the different cases I'm imagining. > > Thanks, Dave. > > Thanks, Khushboo > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
