Thanks, applied. On Tue, Dec 4, 2018 at 12:46 PM Murtuza Zabuawala <murtuza.zabuaw...@enterprisedb.com> wrote: > > Hi, > > PFA patch, I think the issue is that I have used hard-coded server id for > mocking purpose and that server is not present in the test SQLite database on > some server. > > Please review the attached patch. > > On Tue, Dec 4, 2018 at 5:30 PM Murtuza Zabuawala > <murtuza.zabuaw...@enterprisedb.com> wrote: >> >> Sure Dave, looking into it. >> >> On Tue, Dec 4, 2018 at 5:10 PM Dave Page <dp...@pgadmin.org> wrote: >>> >>> Hi >>> >>> These tests still seem to be failing. Can you take another look please? >>> >>> Thanks. >>> On Tue, Dec 4, 2018 at 11:34 AM <jenk...@pgadmin.org> wrote: >>> > >>> > See >>> > <http://pgabf-jenkins.ox.uk.enterprisedb.com:8080/job/pgadmin4-linux-qa/285/display/redirect?page=changes> >>> > >>> > Changes: >>> > >>> > [Dave Page] Ensure browser toolbar buttons are always shown. >>> > >>> > [Dave Page] Fix utility route check for Windows. >>> > >>> > [Dave Page] Remove file added in error. >>> > >>> > [Dave Page] Hide Radio buttons that should not be shown on the >>> > maintenance dialogue. >>> > >>> > ------------------------------------------ >>> > [...truncated 4.23 MB...] >>> > When maintenance the object with >>> > the REINDEX, >>> > When maintenance object with >>> > default options) >>> > SynonymGetTestCase (Fetch synonym Node URL) >>> > PackageDeleteTestCase (Fetch Package Node URL) >>> > procedureDeleteTestCase (Fetch Procedure Node URL) >>> > PgAgentStatsTestCase (Check the stats of pgAgent job) >>> > procedureDeleteMultipleTestCase (Fetch Procedure Node URL) >>> > ProcedurePutTestCase (Fetch Procedure Node URL) >>> > TestSSLConnection (Test for SSL connection) >>> > ResourceGroupsAddTestCase (Add resource groups) >>> > BackupJobTest (When backup the object with the default >>> > options) >>> > RestoreCreateJobTest (When restore object with option - >>> > Disbale, >>> > When restore the object with Type >>> > of objects, >>> > When restore object with option - >>> > Miscellaneous, >>> > When restore object with option - >>> > Do not save, >>> > When restore object with option - >>> > Queries, >>> > When restore object with default >>> > options, >>> > When restore object with the >>> > sections options, >>> > When restore object with option - >>> > Do not save comments, >>> > When restore object with format >>> > directory) >>> > ProcedureAddTestCase (Fetch Procedure Node URL) >>> > TableUpdateTestCase (Detach partition from existing list >>> > partitioned table, >>> > Create partitions of existing >>> > range partitioned table, >>> > Detach partition from existing >>> > range partitioned table, >>> > Attach partition to existing >>> > range partitioned table, >>> > Attach partition to existing list >>> > partitioned table, >>> > Create partitions of existing >>> > list partitioned table) >>> > ResourceGroupsPutTestCase (Put resource groups) >>> > PgAgentAddTestCase (Add pgAgent job) >>> > PackageEDBFuncsGetTestCase (Fetch Package >>> > Functions/Procedures URL) >>> > RestoreJobTest (When restore the object with the default >>> > options) >>> > PackageDeleteMultipleTestCase (Fetch Package Node URL) >>> > PgAgentPutStepTestCase (Update step with kind, >>> > description, code and error, >>> > Update step with connection type >>> > and string) >>> > ProcedureGetTestCase (Fetch Procedure Node URL) >>> > PackageAddTestCase (Fetch Package Node URL) >>> > >>> > PostgreSQL 10: >>> > >>> > 390 tests passed >>> > 1 test failed: >>> > TestUtilityCheckRouteCase (Check utility path route for >>> > backup utility, >>> > Check utility path route for >>> > maintenance utility, >>> > Check utility path route for >>> > import export utility, >>> > Check utility path route for >>> > restore utility) >>> > 35 tests skipped: >>> > PgAgentPutTestCase (Put pgAgent job) >>> > PgAgentAddScheduleTestCase (Create schedule with >>> > exception in pgAgent job) >>> > PgAgentDeleteStepTestCase (Delete pgAgent Step) >>> > ResourceGroupsGetTestCase (Get resource groups) >>> > BackupCreateJobTest (When backup the object with option - >>> > load via partition root, >>> > When backup the object with >>> > option - Do not save comments,, >>> > When backup the server with >>> > encoding, >>> > When backup the server with >>> > option - Do not save comments,) >>> > SynonymDeleteTestCase (Fetch synonym Node URL) >>> > PackagePutTestCase (Fetch Package Node URL) >>> > TableAddTestCase (Create Hash partitioned table with 2 >>> > partitions) >>> > PgAgentGetTestCase (Get pgAgent job) >>> > PgAgentDeleteScheduleTestCase (Delete pgAgent Schedule) >>> > ResourceGroupsDeleteTestCase (Delete multiple resource >>> > groups, >>> > Delete resource groups) >>> > PgAgentPutScheduleTestCase (Update schedule with repeat, >>> > Update schedule change exception >>> > date and time, >>> > Update schedule delete exception, >>> > Update schedule add exception, >>> > Update schedule with start and >>> > end time) >>> > SynonymAddTestCase (Default Node URL) >>> > SynonymDeleteMultipleTestCase (Fetch synonym Node URL) >>> > PgAgentDeleteTestCase (Delete pgAgent job) >>> > PackageGetTestCase (Fetch Package Node URL) >>> > SynonymPutTestCase (Fetch synonym Node URL) >>> > SynonymGetTestCase (Fetch synonym Node URL) >>> > PackageDeleteTestCase (Fetch Package Node URL) >>> > procedureDeleteTestCase (Fetch Procedure Node URL) >>> > PgAgentStatsTestCase (Check the stats of pgAgent job) >>> > procedureDeleteMultipleTestCase (Fetch Procedure Node URL) >>> > ProcedurePutTestCase (Fetch Procedure Node URL) >>> > TestSSLConnection (Test for SSL connection) >>> > ResourceGroupsAddTestCase (Add resource groups) >>> > RestoreCreateJobTest (When restore object with option - >>> > Do not save comments) >>> > ProcedureAddTestCase (Fetch Procedure Node URL) >>> > ResourceGroupsPutTestCase (Put resource groups) >>> > PgAgentAddStepTestCase (Create step for pgAgent job) >>> > PackageEDBFuncsGetTestCase (Fetch Package >>> > Functions/Procedures URL) >>> > PgAgentAddTestCase (Add pgAgent job) >>> > PackageDeleteMultipleTestCase (Fetch Package Node URL) >>> > PgAgentPutStepTestCase (Update step with kind, >>> > description, code and error, >>> > Update step with connection type >>> > and string) >>> > ProcedureGetTestCase (Fetch Procedure Node URL) >>> > PackageAddTestCase (Fetch Package Node URL) >>> > >>> > PostgreSQL 11: >>> > >>> > 399 tests passed >>> > 0 tests failed >>> > 27 tests skipped: >>> > PgAgentPutTestCase (Put pgAgent job) >>> > PgAgentAddScheduleTestCase (Create schedule with >>> > exception in pgAgent job) >>> > PgAgentDeleteStepTestCase (Delete pgAgent Step) >>> > ResourceGroupsGetTestCase (Get resource groups) >>> > SynonymDeleteTestCase (Fetch synonym Node URL) >>> > PackagePutTestCase (Fetch Package Node URL) >>> > SynonymDeleteMultipleTestCase (Fetch synonym Node URL) >>> > PgAgentGetTestCase (Get pgAgent job) >>> > PgAgentDeleteScheduleTestCase (Delete pgAgent Schedule) >>> > PgAgentPutStepTestCase (Update step with kind, >>> > description, code and error, >>> > Update step with connection type >>> > and string) >>> > PgAgentPutScheduleTestCase (Update schedule with repeat, >>> > Update schedule change exception >>> > date and time, >>> > Update schedule delete exception, >>> > Update schedule add exception, >>> > Update schedule with start and >>> > end time) >>> > SynonymAddTestCase (Default Node URL) >>> > PackageGetTestCase (Fetch Package Node URL) >>> > SynonymGetTestCase (Fetch synonym Node URL) >>> > PackageDeleteTestCase (Fetch Package Node URL) >>> > PgAgentStatsTestCase (Check the stats of pgAgent job) >>> > PgAgentAddTestCase (Add pgAgent job) >>> > TestSSLConnection (Test for SSL connection) >>> > ResourceGroupsAddTestCase (Add resource groups) >>> > SynonymPutTestCase (Fetch synonym Node URL) >>> > ResourceGroupsPutTestCase (Put resource groups) >>> > PgAgentAddStepTestCase (Create step for pgAgent job) >>> > PackageEDBFuncsGetTestCase (Fetch Package >>> > Functions/Procedures URL) >>> > PackageDeleteMultipleTestCase (Fetch Package Node URL) >>> > ResourceGroupsDeleteTestCase (Delete multiple resource >>> > groups, >>> > Delete resource groups) >>> > PgAgentDeleteTestCase (Delete pgAgent job) >>> > PackageAddTestCase (Fetch Package Node URL) >>> > >>> > EDB AS 9.6: >>> > >>> > 405 tests passed >>> > 0 tests failed >>> > 21 tests skipped: >>> > MaintenanceJobTest (When maintenance the object with the >>> > default options) >>> > MaintenanceCreateJobTest (When maintenance the object >>> > with the CLUSTER, >>> > When maintenance object with >>> > VACUUM FULL, >>> > When maintenance object with the >>> > ANALYZE, >>> > When maintenance the object with >>> > the REINDEX, >>> > When maintenance object with >>> > default options) >>> > PgAgentAddStepTestCase (Create step for pgAgent job) >>> > PgAgentAddScheduleTestCase (Create schedule with >>> > exception in pgAgent job) >>> > PgAgentStatsTestCase (Check the stats of pgAgent job) >>> > TableUpdateTestCase (Detach partition from existing list >>> > partitioned table, >>> > Create partitions of existing >>> > range partitioned table, >>> > Detach partition from existing >>> > range partitioned table, >>> > Attach partition to existing >>> > range partitioned table, >>> > Attach partition to existing list >>> > partitioned table, >>> > Create partitions of existing >>> > list partitioned table) >>> > PgAgentAddTestCase (Add pgAgent job) >>> > PgAgentPutTestCase (Put pgAgent job) >>> > BackupCreateJobTest (When backup the server with option - >>> > all queries, >>> > When backup the object with >>> > format tar, >>> > When backup object with default >>> > options, >>> > When backup the object with >>> > option - Do not save comments,, >>> > When backup globals, >>> > When backup the server with >>> > option only_schema, >>> > When backup the object with >>> > option only_data, >>> > When backup the object with >>> > option sections to all data, >>> > When backup the server with >>> > option - Do not save comments,, >>> > When backup the server, >>> > When backup the object with >>> > option - load via partition root, >>> > When backup the object with >>> > option - miscellaneous, >>> > When backup the object with >>> > option - all queries and format custom, >>> > When backup the server with >>> > encoding, >>> > When backup the server with >>> > option - Do not save privilege, tablespace, unlogged table data, >>> > When backup the object with >>> > option - Do not save privilege, tablespace, unlogged table data, >>> > When backup object with format >>> > directory, >>> > When backup the server with >>> > option only_data, >>> > When backup the object with >>> > option - all queries, >>> > When backup the object with >>> > option - format plain and dns_owner, >>> > When backup the server with >>> > option - miscellaneous, >>> > When backup the object with >>> > option only_schema) >>> > TableAddTestCase (Create Hash partitioned table with 2 >>> > partitions, >>> > Create Range partitioned table >>> > with 2 partitions, >>> > Create List partitioned table >>> > with 2 partitions) >>> > TestUtilityCheckRouteCase (Check utility path route for >>> > backup utility, >>> > Check utility path route for >>> > maintenance utility, >>> > Check utility path route for >>> > import export utility, >>> > Check utility path route for >>> > restore utility) >>> > RestoreCreateJobTest (When restore object with option - >>> > Disbale, >>> > When restore the object with Type >>> > of objects, >>> > When restore object with option - >>> > Miscellaneous, >>> > When restore object with option - >>> > Do not save, >>> > When restore object with option - >>> > Queries, >>> > When restore object with default >>> > options, >>> > When restore object with the >>> > sections options, >>> > When restore object with option - >>> > Do not save comments, >>> > When restore object with format >>> > directory) >>> > PgAgentDeleteStepTestCase (Delete pgAgent Step) >>> > PgAgentPutScheduleTestCase (Update schedule with repeat, >>> > Update schedule change exception >>> > date and time, >>> > Update schedule delete exception, >>> > Update schedule add exception, >>> > Update schedule with start and >>> > end time) >>> > BackupJobTest (When backup the object with the default >>> > options) >>> > TestSSLConnection (Test for SSL connection) >>> > PgAgentGetTestCase (Get pgAgent job) >>> > PgAgentPutStepTestCase (Update step with kind, >>> > description, code and error, >>> > Update step with connection type >>> > and string) >>> > PgAgentDeleteTestCase (Delete pgAgent job) >>> > RestoreJobTest (When restore the object with the default >>> > options) >>> > PgAgentDeleteScheduleTestCase (Delete pgAgent Schedule) >>> > >>> > ====================================================================== >>> > >>> > NOTE: Configuring authentication for DESKTOP mode. >>> > pgAdmin 4 - Application Initialisation >>> > ====================================== >>> > >>> > Executing and polling with: 2 NOTICES WITH DATASET >>> > Executing and polling with: 1000 NOTICES WITH DATASET >>> > Executing and polling with: NO NOTICE WITH DATASET >>> > Executing and polling with: 2 NOTICES WITH DATASET >>> > Executing and polling with: 1000 NOTICES WITH DATASET >>> > Executing and polling with: NO NOTICE WITH DATASET >>> > Executing and polling with: 2 NOTICES WITH DATASET >>> > Executing and polling with: 1000 NOTICES WITH DATASET >>> > Executing and polling with: NO NOTICE WITH DATASET >>> > Executing and polling with: 2 NOTICES WITH DATASET >>> > Executing and polling with: 1000 NOTICES WITH DATASET >>> > Executing and polling with: NO NOTICE WITH DATASET >>> > Executing and polling with: 2 NOTICES WITH DATASET >>> > Executing and polling with: 1000 NOTICES WITH DATASET >>> > Executing and polling with: NO NOTICE WITH DATASET >>> > Executing and polling with: 2 NOTICES WITH DATASET >>> > Executing and polling with: 1000 NOTICES WITH DATASET >>> > Executing and polling with: NO NOTICE WITH DATASET >>> > Executing and polling with: 2 NOTICES WITH DATASET >>> > Executing and polling with: 1000 NOTICES WITH DATASET >>> > Executing and polling with: NO NOTICE WITH DATASET >>> > Executing and polling with: 2 NOTICES WITH DATASET >>> > Executing and polling with: 1000 NOTICES WITH DATASET >>> > Executing and polling with: NO NOTICE WITH DATASET >>> > Executing and polling with: 2 NOTICES WITH DATASET >>> > Executing and polling with: 1000 NOTICES WITH DATASET >>> > Executing and polling with: NO NOTICE WITH DATASET >>> > Executing and polling with: 2 NOTICES WITH DATASET >>> > Executing and polling with: 1000 NOTICES WITH DATASET >>> > Executing and polling with: NO NOTICE WITH DATASET >>> > Executing and polling with: 2 NOTICES WITH DATASET >>> > Executing and polling with: 1000 NOTICES WITH DATASET >>> > Executing and polling with: NO NOTICE WITH DATASET >>> > Please check output in file: >>> > <http://pgabf-jenkins.ox.uk.enterprisedb.com:8080/job/pgadmin4-linux-qa/ws/web/regression/regression.log> >>> > >>> > ERROR: Error detected when running the Python tests. >>> > kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... >>> > or kill -l [sigspec] >>> > Build step 'Execute shell' marked build as failure >>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company
-- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company