Thanks patch applied. On Thu, Jan 17, 2019 at 11:59 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers, > > Attached is the small patch (and probably the final for this mail chain) > to accommodate the changes suggested in previous mail. > > Kindly review. > > On Wed, Jan 16, 2019 at 8:30 PM Dave Page <dave.p...@enterprisedb.com> > wrote: > >> >> >> On Wed, Jan 16, 2019 at 6:29 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Thanks patch applied without Tree Changes. >>> >>> On Mon, Jan 14, 2019 at 10:55 AM Aditya Toshniwal <aditya.toshniwal@ >>> enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Attached is the patch for further design improvements: >>>> - Process watcher made fixed width with header changes, time details >>>> rounded to 2 decimals >>>> - Query history will show "No query history" if no query fired. Query >>>> editor default size increased. >>>> - Tree improvements - right bold border removed completely. Now click >>>> anywhere on a tree item to perform actions. Please note, single click on >>>> the tiny tree arrow button will not work with this. Clicking anywhere is >>>> more useful than this. >>>> >>> @Dave Should we proceed with this behaviour, I haven't commit it. >>> >> >> I like the blue bit, so that should come back. >> >> I would say that a single-click on the arrow should open/close the node, >> whilst a double-click on the icon or label should open/close it. >> >> >>> - Fixed a bug where New folder create button not working when in List >>>> mode and No files/folder present. >>>> - Other minor improvements. >>>> >>>> Kindly review. >>>> >>>> On Mon, Jan 7, 2019 at 3:17 PM Aditya Toshniwal < >>>> aditya.toshni...@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch for few more changes: >>>>> - New Folder button was not working in file dialogue. Fixed that. >>>>> - Color, icon changes in file dialogue >>>>> - Also replaced the splash screen image (which is used on main >>>>> dashboard also). It works fine on dashboard. However, I'm not sure of the >>>>> splash screen as the new image is SVG and older was PNG. I have made >>>>> changes for that in runtime code but I'm not able to test (evnvironment >>>>> issue) runtime code :(. It would be helpful if someone else can try it >>>>> once. >>>>> >>>>> Kindly review. >>>>> >>>>> >>>>> On Mon, Jan 7, 2019 at 2:25 PM Dave Page <dp...@pgadmin.org> wrote: >>>>> >>>>>> Thanks - applied! >>>>>> >>>>>> On Mon, Jan 7, 2019 at 10:44 AM Aditya Toshniwal >>>>>> <aditya.toshni...@enterprisedb.com> wrote: >>>>>> > >>>>>> > Hi Hackers, >>>>>> > >>>>>> > Attached is the patch to incorporate the changes discussed in >>>>>> trailing mail(s). >>>>>> > >>>>>> > Kindly review. >>>>>> > >>>>>> > On Fri, Jan 4, 2019 at 3:31 PM Dave Page <dp...@pgadmin.org> wrote: >>>>>> >> >>>>>> >> On Fri, Jan 4, 2019 at 9:58 AM Aditya Toshniwal >>>>>> >> <aditya.toshni...@enterprisedb.com> wrote: >>>>>> >> > >>>>>> >> > Hi, >>>>>> >> > >>>>>> >> > On Fri, Jan 4, 2019 at 2:53 PM Dave Page <dp...@pgadmin.org> >>>>>> wrote: >>>>>> >> >> >>>>>> >> >> Hi >>>>>> >> >> >>>>>> >> >> On Fri, Jan 4, 2019 at 4:51 AM Aditya Toshniwal < >>>>>> aditya.toshni...@enterprisedb.com> wrote: >>>>>> >> >>> >>>>>> >> >>> Hi Dave, >>>>>> >> >>> >>>>>> >> >>> On Thu, Jan 3, 2019 at 8:39 PM Dave Page <dp...@pgadmin.org> >>>>>> wrote: >>>>>> >> >>>> >>>>>> >> >>>> >>>>>> >> >>>> A few other things that I noticed (or have been bugging me): >>>>>> >> >>>> >>>>>> >> >>>> - The menu bar seems a little cramped. Taking pg-navbar from >>>>>> 32 to 40px and setting the font-weight to normal on the menu options (but >>>>>> not the product name) seems much better to me (and adjusting everything >>>>>> else as required of course). >>>>>> >> >>> >>>>>> >> >>> Giving too much space for the navbar will reduce the usable >>>>>> space for other things. It is good enough(32) to be used easily, and is >>>>>> equal to all the other headers in app (including tabs) giving a feel of >>>>>> native desktop application. You'll find even smaller menu heights in >>>>>> native >>>>>> desktop application. We can make font weight to normal and may be >>>>>> slightly >>>>>> increase horizontal spacing between the menu links. >>>>>> >> >> >>>>>> >> >> >>>>>> >> >> 8 pixels isn't going to make a noticeable difference to the >>>>>> workspace for users, and would leave the bar smaller than the 50px it's >>>>>> been for the last couple of years (iirc). I think it needs it to avoid >>>>>> looking cramped - please make the change. >>>>>> >> > >>>>>> >> > Will do. >>>>>> >> > One more doubt regarding bold headers, should I remove bold >>>>>> headers in dashboard graph header, subnode headers (eg.table->columns), >>>>>> properties tab accrordian headers ? >>>>>> >> >>>>>> >> No, please don't. I left them bold and the styling seemed like it >>>>>> >> worked. We can tweak again if others disagree later. >>>>>> >> >>>>>> >> Thanks! >>>>>> >> >>>>>> >> BTW - Chrome 71 shows the offset headers in the file dialogue as >>>>>> well. >>>>>> >> >>>>>> >> >>>> >>>>>> >> >>>> - In the file dialogue, the column headers don't line up with >>>>>> the columns in the rows. >>>>>> >> >>> >>>>>> >> >>> I could not see this on my machine (screenshot attached). >>>>>> Could you please share the screenshot. >>>>>> >> >> >>>>>> >> >> >>>>>> >> >> Attached - thanks! This is Chrome 70.0.3538.102 on MacOS. >>>>>> >> >> >>>>>> >> >> -- >>>>>> >> >> Dave Page >>>>>> >> >> Blog: http://pgsnake.blogspot.com >>>>>> >> >> Twitter: @pgsnake >>>>>> >> >> >>>>>> >> >> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> >> >> The Enterprise PostgreSQL Company >>>>>> >> > >>>>>> >> > >>>>>> >> > >>>>>> >> > -- >>>>>> >> > Thanks and Regards, >>>>>> >> > Aditya Toshniwal >>>>>> >> > Software Engineer | EnterpriseDB Software Solutions | Pune >>>>>> >> > "Don't Complain about Heat, Plant a tree" >>>>>> >> >>>>>> >> >>>>>> >> >>>>>> >> -- >>>>>> >> Dave Page >>>>>> >> Blog: http://pgsnake.blogspot.com >>>>>> >> Twitter: @pgsnake >>>>>> >> >>>>>> >> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> >> The Enterprise PostgreSQL Company >>>>>> > >>>>>> > >>>>>> > >>>>>> > -- >>>>>> > Thanks and Regards, >>>>>> > Aditya Toshniwal >>>>>> > Software Engineer | EnterpriseDB Software Solutions | Pune >>>>>> > "Don't Complain about Heat, Plant a tree" >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>>> "Don't Complain about Heat, Plant a tree" >>>>> >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> Aditya Toshniwal >>>> Software Engineer | EnterpriseDB Software Solutions | Pune >>>> "Don't Complain about Heat, Plant a tree" >>>> >>> >>> >>> -- >>> *Akshay Joshi* >>> >>> *Sr. Software Architect * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >> >> >> -- >> Dave Page >> VP, Chief Architect, Tools & Installers >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> > > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB Software Solutions | Pune > "Don't Complain about Heat, Plant a tree" > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
