Hi Murtuza Here are my review comments:
- Exact error should be logged in the log file and on GUI we should show message like "Unable to fetch <function/table> object". - Message should be shown in the status bar. - If there is an error to fetch one kind of object, we should show other objects. On Mon, Jan 28, 2019 at 2:49 PM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi, > > PFA minor patch, To display an error on UI when there is a backend error > for the grant wizard request. > Please review. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > > On Mon, Jan 28, 2019 at 12:48 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks patch applied. >> >> On Mon, Jan 28, 2019 at 12:01 PM Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch to fix the issue where EPAS DB instance running with >>> *no-redwood-compat* mode fails to list down functions objects in grant >>> wizard due to 'char' -> 'int' type cast error. >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >> >> -- >> *Akshay Joshi* >> >> *Sr. Software Architect * >> >> >> >> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >> > -- *Akshay Joshi* *Sr. Software Architect * *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
