Hi Akshay, The issue has been fixed with this patch but I feel we need code refactoring of the existing code especially the loop in which we find the required string. What's your thought?
Also, please remove the datagrid/__init__.py file from the patch which I assume you have sent by mistake. Thanks, Khushboo On Tue, Jan 29, 2019 at 4:49 PM Dave Page <dp...@pgadmin.org> wrote: > Khushboo, can you review this please? If you're happy with it, Akshay > can commit. > > Thanks. > > On Mon, Jan 28, 2019 at 12:33 PM Akshay Joshi > <akshay.jo...@enterprisedb.com> wrote: > > > > Hi Hackers, > > > > Attached is the patch to fix RM 3927 "Unable to debug the procedure > inside package". Problem with the existing code is we assume that > "PLDBGBREAK" will be always found in the first element of the notification > list. > > > > In this patch we loop through the list and found the string. Apart from > that patch contains small fix to cancel the transaction of Query Tool when > panel is closed. > > > > Please review it. > > > > -- > > Akshay Joshi > > Sr. Software Architect > > > > > > Phone: +91 20-3058-9517 > > Mobile: +91 976-788-8246 > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > >
