Thanks patch applied. On Thu, Apr 11, 2019 at 11:30 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote:
> Hi Akshay, > > On Thu, Apr 4, 2019 at 7:02 PM Akshay Joshi <akshay.jo...@enterprisedb.com> > wrote: > >> Hi Khushboo >> >> Below are the review comments: >> >> - Can you please add the help message for 'Default' in note control >> as we do have for 'From/To' control. Also strings are not properly aligned >> in the note control for Partition Keys and Partitions. >> >> Fixed. > >> >> - Update the documentation and screenshot with the new changes. >> >> Done. > >> >> - Found one issue, Steps to reproduce: >> - Create a partition table with range partition and one child >> partition of type 'Default'. >> - Open the properties dialog of the newly created partition table >> and add new child partition with 'Default' = No. Insert all the >> required >> field 'Name', 'From' and 'To', still save button is disabled. I am not >> able >> to create a new child partition. >> >> Fixed > >> >> - If possible can you please fix the RM #*3327* which seems to be a >> small fix, with the same patch. >> >> This fix will affect all the subnode controls as the code is generic. I > will handle this separately. > > Thanks, > Khushboo > >> >> On Wed, Apr 3, 2019 at 3:42 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix: >>> >>> 1. # 4104 - Edit data tables with primary key spanning multiple >>> columns [Partition table] >>> Issue: The partition table having multiple primary keys are not editable >>> from the View data. >>> 2. # 3938 - Properties of table with default partition not displayed >>> Issue: The DEFAULT partition is not supported introduced in PG 11. >>> >>> Thanks, >>> Khushboo >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
