Hi Murtuza I have tested the patch and I think below string should be modified: Server(Type: #ppas) is not supported for the Resource Groups module - Skipped Server version(120000) is not supported for the Resource Groups module - Skipped
It misleads, that server type 'ppas' is not supported for the Resource Group, it should be changed to "Resource groups are not supported by PG - Skipped". Similarly for version string should be ''Resource groups are not supported by PPAS server less/greater than <server version>" Apart from the above code looks good to me. On Wed, Jul 3, 2019 at 9:23 AM Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > > Please note that our framework considers test cases from all the modules > as one single test case, If we need module wise detailed summary report for > the reverse engineered SQL tests then we may have to change the framework. > > > Regards, > Murtuza > > > On Tue, Jul 2, 2019 at 5:52 PM Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> On Tue, Jul 2, 2019 at 8:17 AM Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> ++ Attaching patch >>> >>> On Tue, Jul 2, 2019 at 12:46 PM Murtuza Zabuawala < >>> murtuza.zabuaw...@enterprisedb.com> wrote: >>> >>>> Hi Dave, >>>> >>>> Please find the updated patch, >>>> >>>> - Added a mechanism to check for supported minimum/maximum version and >>>> a server type in the framework. >>>> >>> >> There's still a problem with this I'm afraid - it says in the summary >> that the re_sql test cases were all skipped, which is not the case. I think >> we should just skip the irrelevant tests in the re_sql module, but not mark >> the entire module as being skipped: >> > >> =============Running the test cases for 'Regression - PG 11'============= >> >> runTest (regression.re_sql.tests.test_resql.ReverseEngineeredSQLTestCases) >> >> Reverse Engineered SQL Test Cases >> >> >> Create IMPLICIT Cast >> >> Alter IMPLICIT Cast >> >> Drop IMPLICIT Cast >> >> Create EXPLICIT Cast >> >> Alter EXPLICIT Cast >> >> Drop EXPLICIT Cast >> >> ... skipped 'Server(Type: #ppas) is not supported for the Resource >> Groups module' >> >> >> ---------------------------------------------------------------------- >> >> Ran 1 test in 0.480s >> >> >> OK (skipped=1) >> >> >> ====================================================================== >> >> Test Result Summary >> >> ====================================================================== >> >> >> Regression - PG 11: >> >> >> 0 tests passed >> >> 0 tests failed >> >> 1 test skipped: >> >> ReverseEngineeredSQLTestCases (Reverse Engineered SQL Test Cases) >> >> >> ====================================================================== >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*
