On Tue, Jul 23, 2019 at 2:17 AM Yosry Muhammad <yosry...@gmail.com> wrote:
> Hi, > > I tried just removing the lines responsible for connecting to the database > on selecting a database node and it seem to work fine. Specifically the > lines 254-257 in database.js (callbacks.selected function). > > Are there any specific scenarios I need to test to make sure everything is > okay? Anywhere else in the code where I need to make changes? > > I think all the right side panels (i.e. Properties, SQL, etc...) will be affected. > I also checked the tree state restore and it seems to work fine. > > Thanks. > > > On Fri, Jul 19, 2019 at 7:01 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Thu, Jul 18, 2019 at 1:44 PM Dave Page <dp...@pgadmin.org> wrote: >> >>> Hi >>> >>> On Thu, Jul 18, 2019 at 6:40 AM Yosry Muhammad <yosry...@gmail.com> >>> wrote: >>> >>>> Hi, >>>> >>>> On Thu, Jul 18, 2019, 7:27 AM Khushboo Vashi < >>>> khushboo.va...@enterprisedb.com> wrote: >>>> >>>>> Hi Yosry, >>>>> >>>>> On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad <yosry...@gmail.com> >>>>> wrote: >>>>> >>>>>> Hi Khushboo, >>>>>> >>>>>> There's a minor bug that I noticed a while back that when you right >>>>>> click a disconnected database (to drop it for example) it automatically >>>>>> connects to the database and expands the node. This behaviour is a little >>>>>> annoying to users (me too), I am trying to fix it. >>>>>> >>>>>> This behavior is by design as we have considered some of the pgAdmin >>>>> III behavior. One behavior we can change is that on the selection of the >>>>> database node, we can just connect it and not expand it and when we expand >>>>> the database node (by arrow icon or double click), we can connect and >>>>> expand both. >>>>> >>>>> We need Dave's approval to change this. >>>>> >>>> >>>> I think this makes more sense. >>>> >>> >>> pgAdmin 3 automatically connects databases on select but not servers. >>> I'd be fine with only connecting databases and servers on expand, and not >>> on select. That should not affect auto-expand and treeview state restore at >>> all, but will mean you can right-click a database or server without it >>> connecting. FYI, I've found this behaviour annoying too. >>> >>> This change will definitely affect the auto-expand and tree-view state >> restore, but that can be handled by some code changes. >> >>> I can't imagine it would require hacking aciTree to make that happen - >>> we'd basically just move the connect function call from the onSelect >>> handler (or whatever it's called) to onExpand wouldn't we? >>> >> Right, as we have implemented both expand and select calls, we just need >> to remove the select handler. >> >>> >>> >>>> >>>> >>>>> I looked around the code in the browser module (node.js, database.js, >>>>>> menu.js) and I couldn't find a way to modify this behaviour. Is this >>>>>> handled internally by jQuery? Is modifying this behaviour feasible? >>>>>> >>>>>> >>>>> I think the problem is that the right click event triggers the left >>>>>> event click too. Am I correct? >>>>>> >>>>>> Basically, the browser tree is generated through the aciTree library, >>>>> so when required, the public APIs (provided by aciTree) of the events are >>>>> being called. >>>>> In this case, on the selection of the database node, the selected >>>>> event is used in the database.js file. >>>>> >>>>> Thanks for the clarification. >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> > > -- > *Yosry Muhammad Yosry* > > Computer Engineering student, > The Faculty of Engineering, > Cairo University (2021). > Class representative of CMP 2021. > https://www.linkedin.com/in/yosrym93/ >
